mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH v2] regulator: provide regulator_get_name() stub for !CONFIG_REGULATOR
@ 2020-09-15  9:44 Ahmad Fatoum
  2020-09-15 10:22 ` Roland Hieber
  2020-09-15 12:35 ` Sascha Hauer
  0 siblings, 2 replies; 3+ messages in thread
From: Ahmad Fatoum @ 2020-09-15  9:44 UTC (permalink / raw)
  To: barebox; +Cc: Roland Hieber

Otherwise users of this function run into a link error when regulator
support is compiled out.

Reported-by: Roland Hieber <rhi@pengutronix.de>
Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
---
Forgot to commit a deleted semicolon..
---
 include/regulator.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/include/regulator.h b/include/regulator.h
index 12d8e816cdb1..a9cb6dedca5e 100644
--- a/include/regulator.h
+++ b/include/regulator.h
@@ -175,6 +175,11 @@ static inline struct regulator *regulator_get(struct device_d *dev, const char *
 	return NULL;
 }
 
+static inline struct regulator *regulator_get_name(const char *name)
+{
+	return NULL;
+}
+
 static inline int regulator_enable(struct regulator *r)
 {
 	return 0;
-- 
2.28.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] regulator: provide regulator_get_name() stub for !CONFIG_REGULATOR
  2020-09-15  9:44 [PATCH v2] regulator: provide regulator_get_name() stub for !CONFIG_REGULATOR Ahmad Fatoum
@ 2020-09-15 10:22 ` Roland Hieber
  2020-09-15 12:35 ` Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Roland Hieber @ 2020-09-15 10:22 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox

On Tue, Sep 15, 2020 at 11:44:17AM +0200, Ahmad Fatoum wrote:
> Otherwise users of this function run into a link error when regulator
> support is compiled out.
> 
> Reported-by: Roland Hieber <rhi@pengutronix.de>
> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>

Thanks!
Tested-by: Roland Hieber <rhi@pengutronix.de>

> ---
> Forgot to commit a deleted semicolon..
> ---
>  include/regulator.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/include/regulator.h b/include/regulator.h
> index 12d8e816cdb1..a9cb6dedca5e 100644
> --- a/include/regulator.h
> +++ b/include/regulator.h
> @@ -175,6 +175,11 @@ static inline struct regulator *regulator_get(struct device_d *dev, const char *
>  	return NULL;
>  }
>  
> +static inline struct regulator *regulator_get_name(const char *name)
> +{
> +	return NULL;
> +}
> +
>  static inline int regulator_enable(struct regulator *r)
>  {
>  	return 0;
> -- 
> 2.28.0
> 
> 

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] regulator: provide regulator_get_name() stub for !CONFIG_REGULATOR
  2020-09-15  9:44 [PATCH v2] regulator: provide regulator_get_name() stub for !CONFIG_REGULATOR Ahmad Fatoum
  2020-09-15 10:22 ` Roland Hieber
@ 2020-09-15 12:35 ` Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2020-09-15 12:35 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox, Roland Hieber

On Tue, Sep 15, 2020 at 11:44:17AM +0200, Ahmad Fatoum wrote:
> Otherwise users of this function run into a link error when regulator
> support is compiled out.
> 
> Reported-by: Roland Hieber <rhi@pengutronix.de>
> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
> ---
> Forgot to commit a deleted semicolon..
> ---
>  include/regulator.h | 5 +++++
>  1 file changed, 5 insertions(+)

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-09-15 12:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-15  9:44 [PATCH v2] regulator: provide regulator_get_name() stub for !CONFIG_REGULATOR Ahmad Fatoum
2020-09-15 10:22 ` Roland Hieber
2020-09-15 12:35 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox