mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] scripts/kwbimage: Fix a build warning
@ 2020-09-15  9:37 Uwe Kleine-König
  2020-09-15 12:34 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Uwe Kleine-König @ 2020-09-15  9:37 UTC (permalink / raw)
  To: barebox

This fixes:

	scripts/kwbimage.c:253:5: warning: no previous prototype for ‘image_nand_ecc_mode_id’ [-Wmissing-prototypes]

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 scripts/kwbimage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/kwbimage.c b/scripts/kwbimage.c
index db66f7060dcb..26eb07fa81bc 100644
--- a/scripts/kwbimage.c
+++ b/scripts/kwbimage.c
@@ -250,7 +250,7 @@ static const char *image_nand_ecc_mode_name(unsigned int id)
 	return NULL;
 }
 
-int image_nand_ecc_mode_id(const char *nand_ecc_mode_name)
+static int image_nand_ecc_mode_id(const char *nand_ecc_mode_name)
 {
 	int i;
 	for (i = 0; nand_ecc_modes[i].name; i++)
-- 
2.27.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] scripts/kwbimage: Fix a build warning
  2020-09-15  9:37 [PATCH] scripts/kwbimage: Fix a build warning Uwe Kleine-König
@ 2020-09-15 12:34 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2020-09-15 12:34 UTC (permalink / raw)
  To: Uwe Kleine-König; +Cc: barebox

On Tue, Sep 15, 2020 at 11:37:21AM +0200, Uwe Kleine-König wrote:
> This fixes:
> 
> 	scripts/kwbimage.c:253:5: warning: no previous prototype for ‘image_nand_ecc_mode_id’ [-Wmissing-prototypes]
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  scripts/kwbimage.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/kwbimage.c b/scripts/kwbimage.c
> index db66f7060dcb..26eb07fa81bc 100644
> --- a/scripts/kwbimage.c
> +++ b/scripts/kwbimage.c
> @@ -250,7 +250,7 @@ static const char *image_nand_ecc_mode_name(unsigned int id)
>  	return NULL;
>  }
>  
> -int image_nand_ecc_mode_id(const char *nand_ecc_mode_name)
> +static int image_nand_ecc_mode_id(const char *nand_ecc_mode_name)

I already have this in another patch which also fixes this type of
problem for the other cases in scripts/

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-09-15 12:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-15  9:37 [PATCH] scripts/kwbimage: Fix a build warning Uwe Kleine-König
2020-09-15 12:34 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox