From: Marco Felsch <m.felsch@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 5/7] mtd: nand-mxs: fix out-of-bounds write on 64-bit SoCs
Date: Mon, 28 Sep 2020 18:01:02 +0200 [thread overview]
Message-ID: <20200928160102.GA20189@pengutronix.de> (raw)
In-Reply-To: <20200928154247.15619-5-a.fatoum@pengutronix.de>
On 20-09-28 17:42, Ahmad Fatoum wrote:
> Probing the nand_mxs device driver on 64 bit systems invokes
> undefined behavior, because of an errant cast. Fix this.
>
> No change of behavior for 32-bit SoCs intended.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> drivers/mtd/nand/nand_mxs.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/nand_mxs.c b/drivers/mtd/nand/nand_mxs.c
> index 36b6e7ac224e..e2b6e2162076 100644
> --- a/drivers/mtd/nand/nand_mxs.c
> +++ b/drivers/mtd/nand/nand_mxs.c
> @@ -2145,9 +2145,7 @@ static int mxs_nand_probe(struct device_d *dev)
> if (mxs_nand_mtd)
> return -EBUSY;
>
> - err = dev_get_drvdata(dev, (const void **)&type);
> - if (err)
> - type = GPMI_MXS;
> + type = (enum gpmi_type)device_get_match_data(dev);
Should we add:
if (!type)
type = GPMI_MXS;
here?
> nand_info = kzalloc(sizeof(struct mxs_nand_info), GFP_KERNEL);
> if (!nand_info) {
> --
> 2.28.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-09-28 16:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 15:42 [PATCH 1/7] driver: introduce less error-prone dev_get_drvdata alternative Ahmad Fatoum
2020-09-28 15:42 ` [PATCH 2/7] led: pca955x: fix probing from device tree Ahmad Fatoum
2020-09-29 7:19 ` Sascha Hauer
2020-09-30 7:28 ` Ahmad Fatoum
2020-09-28 15:42 ` [PATCH 3/7] dma: apbh: fix out-of-bounds write on 64-bit SoCs Ahmad Fatoum
2020-09-28 15:42 ` [PATCH 4/7] aiodev: lm75: " Ahmad Fatoum
2020-09-28 15:42 ` [PATCH 5/7] mtd: nand-mxs: " Ahmad Fatoum
2020-09-28 16:01 ` Marco Felsch [this message]
2020-09-28 16:03 ` Ahmad Fatoum
2020-09-28 16:08 ` Marco Felsch
2020-09-28 15:42 ` [PATCH 6/7] video: imx-hdmi: fix dev_get_drvdata misuse Ahmad Fatoum
2020-09-28 15:42 ` [PATCH 7/7] driver: migrate some from dev_get_drvdata to device_get_match_data Ahmad Fatoum
2020-09-28 15:46 ` [PATCH 1/7] driver: introduce less error-prone dev_get_drvdata alternative Ahmad Fatoum
2020-09-29 6:45 ` Sascha Hauer
2020-09-29 7:32 ` Sascha Hauer
2020-09-29 9:42 ` Ahmad Fatoum
2020-09-30 7:48 ` Sascha Hauer
2020-09-30 13:13 ` Ahmad Fatoum
2020-10-05 8:31 ` Ahmad Fatoum
2020-10-07 8:43 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200928160102.GA20189@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox