[PATCH] scripts/dtc: only append to HOST_EXTRACFLAGS instead of overwriting

[PATCH] scripts/dtc: only append to HOST_EXTRACFLAGS instead of overwriting

[Uwe Kleine-König]

This corresponds to Linux commit 7e2521a85c98 (that currently sits in
linux-next) with the same short log.

When building with

	$ HOST_EXTRACFLAGS=-g make

the expectation is that host tools are built with debug informations.
This however doesn't happen if the Makefile assigns a new value to the
HOST_EXTRACFLAGS instead of appending to it. So use += instead of := for
the first assignment.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 scripts/dtc/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/dtc/Makefile b/scripts/dtc/Makefile
index 06a265cf7b51..721e8e2b8c2e 100644
--- a/scripts/dtc/Makefile
+++ b/scripts/dtc/Makefile
@@ -14,7 +14,7 @@ libfdt-objs	:= $(libfdt-objs:%.o=libfdt/%.o)
 fdtget-objs    += fdtget.o $(libfdt-objs) util.o
 
 # Source files need to get at the userspace version of libfdt_env.h to compile
-HOST_EXTRACFLAGS := -I$(src)/libfdt
+HOST_EXTRACFLAGS += -I$(src)/libfdt
 
 ifeq ($(wildcard /usr/include/yaml.h),)
 ifneq ($(CHECK_DTBS),)
-- 
2.28.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] scripts/dtc: only append to HOST_EXTRACFLAGS instead of overwriting

[Sascha Hauer]

On Tue, Sep 29, 2020 at 01:54:57PM +0200, Uwe Kleine-König wrote:
> This corresponds to Linux commit 7e2521a85c98 (that currently sits in
> linux-next) with the same short log.
> 
> When building with
> 
> 	$ HOST_EXTRACFLAGS=-g make
> 
> the expectation is that host tools are built with debug informations.
> This however doesn't happen if the Makefile assigns a new value to the
> HOST_EXTRACFLAGS instead of appending to it. So use += instead of := for
> the first assignment.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  scripts/dtc/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/scripts/dtc/Makefile b/scripts/dtc/Makefile
> index 06a265cf7b51..721e8e2b8c2e 100644
> --- a/scripts/dtc/Makefile
> +++ b/scripts/dtc/Makefile
> @@ -14,7 +14,7 @@ libfdt-objs	:= $(libfdt-objs:%.o=libfdt/%.o)
>  fdtget-objs    += fdtget.o $(libfdt-objs) util.o
>  
>  # Source files need to get at the userspace version of libfdt_env.h to compile
> -HOST_EXTRACFLAGS := -I$(src)/libfdt
> +HOST_EXTRACFLAGS += -I$(src)/libfdt
>  
>  ifeq ($(wildcard /usr/include/yaml.h),)
>  ifneq ($(CHECK_DTBS),)
> -- 
> 2.28.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox