From: Sascha Hauer <s.hauer@pengutronix.de>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] shutdown: flush console on barebox shutdown
Date: Fri, 2 Oct 2020 06:22:06 +0200 [thread overview]
Message-ID: <20201002042206.GS11648@pengutronix.de> (raw)
In-Reply-To: <20200930132451.354162-1-l.stach@pengutronix.de>
On Wed, Sep 30, 2020 at 03:24:51PM +0200, Lucas Stach wrote:
> Same as in the poweroff and restart path, we should make sure to properly
> drain the console devices when shutting down barebox. This fixes serial
> console corruption when the software running after barebox changes the
> peripheral configuration before all the characters have drained out of
> the FIFO.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> common/startup.c | 2 ++
> 1 file changed, 2 insertions(+)
Applied, thanks
Sascha
>
> diff --git a/common/startup.c b/common/startup.c
> index 1c58e412885f..7d44123941da 100644
> --- a/common/startup.c
> +++ b/common/startup.c
> @@ -418,6 +418,8 @@ void shutdown_barebox(void)
> pr_debug("exitcall-> %pS\n", *exitcall);
> (*exitcall)();
> }
> +
> + console_flush();
> }
>
> BAREBOX_MAGICVAR_NAMED(autoboot_state,
> --
> 2.20.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2020-10-02 4:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 13:24 Lucas Stach
2020-10-02 4:22 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002042206.GS11648@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=l.stach@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox