From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQ4T3-0008Kw-SK for barebox@lists.infradead.org; Wed, 07 Oct 2020 08:06:34 +0000 Date: Wed, 7 Oct 2020 10:06:32 +0200 From: Sascha Hauer Message-ID: <20201007080632.GK11648@pengutronix.de> References: <20201005080643.25199-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201005080643.25199-1-a.fatoum@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] bootm: propagate register_image_handler return value To: Ahmad Fatoum Cc: barebox@lists.infradead.org On Mon, Oct 05, 2020 at 10:06:43AM +0200, Ahmad Fatoum wrote: > While register_image_handler can't currently fail, it still returns an > error code. Propagate that error code along instead of having a blanket > return 0. This makes the code a little more compact. > > Signed-off-by: Ahmad Fatoum > --- > arch/arm/mach-stm32mp/stm32image.c | 4 +--- > arch/arm/mach-zynq/bootm-zynqimg.c | 4 +--- > 2 files changed, 2 insertions(+), 6 deletions(-) Applied, thanks Sascha > > diff --git a/arch/arm/mach-stm32mp/stm32image.c b/arch/arm/mach-stm32mp/stm32image.c > index 84975c5c3bf1..207df6894d4e 100644 > --- a/arch/arm/mach-stm32mp/stm32image.c > +++ b/arch/arm/mach-stm32mp/stm32image.c > @@ -43,8 +43,6 @@ static struct image_handler image_handler_stm32_image_v1_handler = { > > static int stm32mp_register_stm32image_image_handler(void) > { > - register_image_handler(&image_handler_stm32_image_v1_handler); > - > - return 0; > + return register_image_handler(&image_handler_stm32_image_v1_handler); > } > late_initcall(stm32mp_register_stm32image_image_handler); > diff --git a/arch/arm/mach-zynq/bootm-zynqimg.c b/arch/arm/mach-zynq/bootm-zynqimg.c > index e903ab667905..77ed6880e4b6 100644 > --- a/arch/arm/mach-zynq/bootm-zynqimg.c > +++ b/arch/arm/mach-zynq/bootm-zynqimg.c > @@ -42,8 +42,6 @@ static struct image_handler zynq_image_handler = { > > static int zynq_register_image_handler(void) > { > - register_image_handler(&zynq_image_handler); > - > - return 0; > + return register_image_handler(&zynq_image_handler); > } > late_initcall(zynq_register_image_handler); > -- > 2.28.0 > > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox