From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jules Maselbas <jmaselbas@kalray.eu>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] usb: dwc2: Uninitialize host and device on remove
Date: Fri, 9 Oct 2020 09:21:44 +0200 [thread overview]
Message-ID: <20201009072144.GY11648@pengutronix.de> (raw)
In-Reply-To: <20201008151143.30303-1-jmaselbas@kalray.eu>
On Thu, Oct 08, 2020 at 05:11:43PM +0200, Jules Maselbas wrote:
> Device gadget must be properly uninitialized on poweroff however host
> system might not detect barebox's usb gadget has beeing disconnected.
>
> Signed-off-by: Jules Maselbas <jmaselbas@kalray.eu>
> ---
> drivers/usb/dwc2/dwc2.c | 16 ++--------------
> drivers/usb/dwc2/dwc2.h | 4 ++++
> drivers/usb/dwc2/gadget.c | 6 ++++++
> drivers/usb/dwc2/host.c | 13 +++++++++++++
> 4 files changed, 25 insertions(+), 14 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/usb/dwc2/dwc2.c b/drivers/usb/dwc2/dwc2.c
> index 7a8ba6c4f..894307bd4 100644
> --- a/drivers/usb/dwc2/dwc2.c
> +++ b/drivers/usb/dwc2/dwc2.c
> @@ -15,19 +15,6 @@
>
> #include "dwc2.h"
>
> -static void dwc2_uninit_common(struct dwc2 *dwc2)
> -{
> - uint32_t hprt0;
> -
> - hprt0 = dwc2_readl(dwc2, HPRT0);
> -
> - /* Put everything in reset. */
> - hprt0 &= ~(HPRT0_ENA | HPRT0_ENACHG | HPRT0_CONNDET | HPRT0_OVRCURRCHG);
> - hprt0 |= HPRT0_RST;
> -
> - dwc2_writel(dwc2, hprt0, HPRT0);
> -}
> -
> static int dwc2_set_mode(void *ctx, enum usb_dr_mode mode)
> {
> struct dwc2 *dwc2 = ctx;
> @@ -98,7 +85,8 @@ static void dwc2_remove(struct device_d *dev)
> {
> struct dwc2 *dwc2 = dev->priv;
>
> - dwc2_uninit_common(dwc2);
> + dwc2_host_uninit(dwc2);
> + dwc2_gadget_uninit(dwc2);
> }
>
> static const struct of_device_id dwc2_platform_dt_ids[] = {
> diff --git a/drivers/usb/dwc2/dwc2.h b/drivers/usb/dwc2/dwc2.h
> index 2475fd005..01a4ec2ca 100644
> --- a/drivers/usb/dwc2/dwc2.h
> +++ b/drivers/usb/dwc2/dwc2.h
> @@ -37,13 +37,17 @@ int dwc2_submit_roothub(struct dwc2 *dwc2, struct usb_device *dev,
> unsigned long pipe, void *buf, int len,
> struct devrequest *setup);
> int dwc2_register_host(struct dwc2 *dwc2);
> +void dwc2_host_uninit(struct dwc2 *dwc2);
> #else
> static inline int dwc2_register_host(struct dwc2 *dwc2) { return -ENODEV; }
> +static inline void dwc2_host_uninit(struct dwc2 *dwc2) {};
> #endif
>
> /* Gadget functions */
> #ifdef CONFIG_USB_DWC2_GADGET
> int dwc2_gadget_init(struct dwc2 *dwc2);
> +void dwc2_gadget_uninit(struct dwc2 *dwc2);
> #else
> static inline int dwc2_gadget_init(struct dwc2 *dwc2) { return -ENODEV; }
> +static inline void dwc2_gadget_uninit(struct dwc2 *dwc2) {};
> #endif
> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
> index 6a65b9b11..aa7447c9b 100644
> --- a/drivers/usb/dwc2/gadget.c
> +++ b/drivers/usb/dwc2/gadget.c
> @@ -2734,3 +2734,9 @@ int dwc2_gadget_init(struct dwc2 *dwc2)
>
> return 0;
> }
> +
> +void dwc2_gadget_uninit(struct dwc2 *dwc2)
> +{
> + dwc2_core_disconnect(dwc2);
> + dwc2_gadget_disconnect(dwc2);
> +}
> diff --git a/drivers/usb/dwc2/host.c b/drivers/usb/dwc2/host.c
> index 59a2aac47..f95ec4e56 100644
> --- a/drivers/usb/dwc2/host.c
> +++ b/drivers/usb/dwc2/host.c
> @@ -779,3 +779,16 @@ int dwc2_register_host(struct dwc2 *dwc2)
>
> return usb_register_host(host);
> }
> +
> +void dwc2_host_uninit(struct dwc2 *dwc2)
> +{
> + uint32_t hprt0;
> +
> + hprt0 = dwc2_readl(dwc2, HPRT0);
> +
> + /* Put everything in reset. */
> + hprt0 &= ~(HPRT0_ENA | HPRT0_ENACHG | HPRT0_CONNDET | HPRT0_OVRCURRCHG);
> + hprt0 |= HPRT0_RST;
> +
> + dwc2_writel(dwc2, hprt0, HPRT0);
> +}
> --
> 2.17.1
>
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2020-10-09 7:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 15:11 Jules Maselbas
2020-10-09 7:21 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201009072144.GY11648@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=jmaselbas@kalray.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox