From: Rouven Czerwinski <r.czerwinski@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Subject: [PATCH] console: add new write-only option
Date: Tue, 13 Oct 2020 09:59:25 +0200 [thread overview]
Message-ID: <20201013075925.2984-1-r.czerwinski@pengutronix.de> (raw)
Add CONFIG_CONSOLE_WRITEONLY to configure the consoles as write-only,
making the bootup effectively non-interactive.
Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
---
common/Kconfig | 11 +++++++++++
common/console.c | 2 +-
common/console_simple.c | 5 ++++-
common/startup.c | 5 +++++
4 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/common/Kconfig b/common/Kconfig
index 1a5bb53182..abf9b7bd73 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -775,6 +775,17 @@ config CONSOLE_ALLOW_COLOR
compile time default for colored console output. After boot it
can be controlled using global.allow_color.
+config CONSOLE_WRITEONLY
+ prompt "Enable writeonly consoles (non-interactive)"
+ depends on CONSOLE_FULL || CONSOLE_SIMPLE
+ bool
+ help
+ If enabled, all consoles are configured to be write-only, meaning
+ they will not read any input, making the console effectively
+ non-interactive.
+ CAUTION: this will also disable input devices, since they are registered as
+ consoles.
+
config PBL_CONSOLE
depends on PBL_IMAGE
depends on !CONSOLE_NONE
diff --git a/common/console.c b/common/console.c
index 3375ecb7e5..fb26886f8c 100644
--- a/common/console.c
+++ b/common/console.c
@@ -93,7 +93,7 @@ int console_set_active(struct console_device *cdev, unsigned flag)
{
int ret;
- if (!cdev->getc)
+ if (!cdev->getc || IS_ENABLED(CONFIG_CONSOLE_WRITEONLY))
flag &= ~CONSOLE_STDIN;
if (!cdev->putc)
flag &= ~(CONSOLE_STDOUT | CONSOLE_STDERR);
diff --git a/common/console_simple.c b/common/console_simple.c
index 42224842c5..75257c7b08 100644
--- a/common/console_simple.c
+++ b/common/console_simple.c
@@ -92,7 +92,10 @@ int console_register(struct console_device *newcdev)
newcdev->setbrg(newcdev, newcdev->baudrate);
}
- newcdev->f_active = CONSOLE_STDIN | CONSOLE_STDOUT | CONSOLE_STDERR;
+ if (IS_ENABLED(CONFIG_CONSOLE_WRITEONLY))
+ newcdev->f_active = CONSOLE_STDOUT | CONSOLE_STDERR;
+ else
+ newcdev->f_active = CONSOLE_STDIN | CONSOLE_STDOUT | CONSOLE_STDERR;
barebox_banner();
diff --git a/common/startup.c b/common/startup.c
index ea7ce6b8da..d7bf99df14 100644
--- a/common/startup.c
+++ b/common/startup.c
@@ -253,6 +253,11 @@ enum autoboot_state do_autoboot_countdown(void)
menu_exists = stat(MENUFILE, &s) == 0;
+ if (IS_ENABLED(CONFIG_CONSOLE_WRITEONLY)) {
+ printf("\nNon-interactive console, booting system\n");
+ return autoboot_state = AUTOBOOT_BOOT;
+ }
+
if (menu_exists) {
printf("\nHit m for menu or %s to stop autoboot: ",
global_autoboot_abort_keys[global_autoboot_abort_key]);
--
2.28.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2020-10-13 7:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 7:59 Rouven Czerwinski [this message]
2020-10-13 8:41 ` Ahmad Fatoum
2020-10-13 9:17 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201013075925.2984-1-r.czerwinski@pengutronix.de \
--to=r.czerwinski@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox