From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: barebox@lists.infradead.org,
Stefan Riedmueller <s.riedmueller@phytec.de>
Subject: Re: [PATCH] ARM: dts: imx6qdl: pfla02: document motivation for dropping supply
Date: Mon, 2 Nov 2020 08:55:56 +0100 [thread overview]
Message-ID: <20201102075556.GP26805@pengutronix.de> (raw)
In-Reply-To: <20201029205615.103515-1-u.kleine-koenig@pengutronix.de>
On Thu, Oct 29, 2020 at 09:56:15PM +0100, Uwe Kleine-König wrote:
> In commit 84cf5cfa9a0e ("ARM: dts: imx6qdl: pfla02: Remove fec
> phy-supply") the phy-supply was removed. The motivation however was only
> given in the commit log. Add a comment accompanying the actual statement
> to remove the property to make this better findable.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> arch/arm/dts/imx6qdl-phytec-pfla02.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
Applied, thanks
Sascha
>
> diff --git a/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi
> index b83511cb011f..7a12e2a06be4 100644
> --- a/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi
> +++ b/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi
> @@ -84,6 +84,11 @@
> };
>
> &fec {
> + /*
> + * barebox doesn't have a driver for the PMIC providing the phy-supply
> + * (dlg,da9063). So remove the phy-supply property and rely on the
> + * PMIC's reset default which has this supply enabled.
> + */
> /delete-property/ phy-supply;
> };
>
> --
> 2.28.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2020-11-02 7:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 20:56 Uwe Kleine-König
2020-11-02 7:55 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102075556.GP26805@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.riedmueller@phytec.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox