mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: imx6qdl: pfla02: Remove eeprom node
Date: Mon, 2 Nov 2020 09:20:23 +0100	[thread overview]
Message-ID: <20201102082023.GS26805@pengutronix.de> (raw)
In-Reply-To: <20201030071350.9691-1-shc_work@mail.ru>

On Fri, Oct 30, 2020 at 10:13:50AM +0300, Alexander Shiyan wrote:
> The upstream dtsi now has a eeprom node, so no need to duplicate
> anymore. Let's keep the "page_size" property for a while.

Patch looks good, so applied, thanks

I just wonder why the pagesize isn't included in the upstream dts.
Shouldn't it be there as well?

Sascha

> 
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
>  arch/arm/dts/imx6qdl-phytec-pfla02.dtsi | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi
> index b83511cb0..d0b056b2f 100644
> --- a/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi
> +++ b/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi
> @@ -155,6 +155,10 @@
>  	barebox,provide-mac-address = <&fec 0x620>;
>  };
>  
> +&som_eeprom {
> +	pagesize = <32>;
> +};
> +
>  &usdhc3 {
>  	#address-cells = <1>;
>  	#size-cells = <1>;
> @@ -175,12 +179,6 @@
>  	pinctrl-0 = <&pinctrl_i2c1>;
>  	status = "okay";
>  
> -	eeprom: eeprom@50 {
> -		compatible = "atmel,24c32";
> -		pagesize = <32>;
> -		reg = <0x50>;
> -	};
> -
>  	pmic@58 {
>  		watchdog-priority = <500>;
>  		restart-priority = <500>;
> -- 
> 2.26.2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2020-11-02  8:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-30  7:13 Alexander Shiyan
2020-11-02  8:20 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201102082023.GS26805@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=shc_work@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox