mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: imx6qdl: pfla02: Remove eeprom node
@ 2020-10-30  7:13 Alexander Shiyan
  2020-11-02  8:20 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Alexander Shiyan @ 2020-10-30  7:13 UTC (permalink / raw)
  To: barebox

The upstream dtsi now has a eeprom node, so no need to duplicate
anymore. Let's keep the "page_size" property for a while.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 arch/arm/dts/imx6qdl-phytec-pfla02.dtsi | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi
index b83511cb0..d0b056b2f 100644
--- a/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi
+++ b/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi
@@ -155,6 +155,10 @@
 	barebox,provide-mac-address = <&fec 0x620>;
 };
 
+&som_eeprom {
+	pagesize = <32>;
+};
+
 &usdhc3 {
 	#address-cells = <1>;
 	#size-cells = <1>;
@@ -175,12 +179,6 @@
 	pinctrl-0 = <&pinctrl_i2c1>;
 	status = "okay";
 
-	eeprom: eeprom@50 {
-		compatible = "atmel,24c32";
-		pagesize = <32>;
-		reg = <0x50>;
-	};
-
 	pmic@58 {
 		watchdog-priority = <500>;
 		restart-priority = <500>;
-- 
2.26.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: dts: imx6qdl: pfla02: Remove eeprom node
  2020-10-30  7:13 [PATCH] ARM: dts: imx6qdl: pfla02: Remove eeprom node Alexander Shiyan
@ 2020-11-02  8:20 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2020-11-02  8:20 UTC (permalink / raw)
  To: Alexander Shiyan; +Cc: barebox

On Fri, Oct 30, 2020 at 10:13:50AM +0300, Alexander Shiyan wrote:
> The upstream dtsi now has a eeprom node, so no need to duplicate
> anymore. Let's keep the "page_size" property for a while.

Patch looks good, so applied, thanks

I just wonder why the pagesize isn't included in the upstream dts.
Shouldn't it be there as well?

Sascha

> 
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
>  arch/arm/dts/imx6qdl-phytec-pfla02.dtsi | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi
> index b83511cb0..d0b056b2f 100644
> --- a/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi
> +++ b/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi
> @@ -155,6 +155,10 @@
>  	barebox,provide-mac-address = <&fec 0x620>;
>  };
>  
> +&som_eeprom {
> +	pagesize = <32>;
> +};
> +
>  &usdhc3 {
>  	#address-cells = <1>;
>  	#size-cells = <1>;
> @@ -175,12 +179,6 @@
>  	pinctrl-0 = <&pinctrl_i2c1>;
>  	status = "okay";
>  
> -	eeprom: eeprom@50 {
> -		compatible = "atmel,24c32";
> -		pagesize = <32>;
> -		reg = <0x50>;
> -	};
> -
>  	pmic@58 {
>  		watchdog-priority = <500>;
>  		restart-priority = <500>;
> -- 
> 2.26.2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-02  8:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-30  7:13 [PATCH] ARM: dts: imx6qdl: pfla02: Remove eeprom node Alexander Shiyan
2020-11-02  8:20 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox