[PATCH] ARM: dts: CCMX51: Increase kernel partition size

[PATCH] ARM: dts: CCMX51: Increase kernel partition size

[Alexander Shiyan]

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 arch/arm/dts/imx51-ccxmx51.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/dts/imx51-ccxmx51.dts b/arch/arm/dts/imx51-ccxmx51.dts
index efe5dbf63..4aa32e4c8 100644
--- a/arch/arm/dts/imx51-ccxmx51.dts
+++ b/arch/arm/dts/imx51-ccxmx51.dts
@@ -31,11 +31,11 @@
 
 	partition@c0000 {
 		label = "kernel";
-		reg = <0xc0000 0x340000>;
+		reg = <0xc0000 0x400000>;
 	};
 
-	partition@400000 {
+	partition@4c0000 {
 		label = "root";
-		reg = <0x400000 0>;
+		reg = <0x4c0000 0>;
 	};
 };
-- 
2.26.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] ARM: dts: CCMX51: Increase kernel partition size

[Uwe Kleine-König]

[-- Attachment #1.1: Type: text/plain, Size: 1307 bytes --]

On Fri, Oct 30, 2020 at 10:31:57AM +0300, Alexander Shiyan wrote:
A few words about the motivation here would be great. Is 0x340000 to
small for a current kernel? Is this following some upstream change? Why
not install the kernel in the rootfs and get rid of the kernel
partition?

Best regards
Uwe

> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
>  arch/arm/dts/imx51-ccxmx51.dts | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/dts/imx51-ccxmx51.dts b/arch/arm/dts/imx51-ccxmx51.dts
> index efe5dbf63..4aa32e4c8 100644
> --- a/arch/arm/dts/imx51-ccxmx51.dts
> +++ b/arch/arm/dts/imx51-ccxmx51.dts
> @@ -31,11 +31,11 @@
>  
>  	partition@c0000 {
>  		label = "kernel";
> -		reg = <0xc0000 0x340000>;
> +		reg = <0xc0000 0x400000>;
>  	};
>  
> -	partition@400000 {
> +	partition@4c0000 {
>  		label = "root";
> -		reg = <0x400000 0>;
> +		reg = <0x4c0000 0>;
>  	};
>  };
> -- 
> 2.26.2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 149 bytes --]

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] ARM: dts: CCMX51: Increase kernel partition size

[Alexander Shiyan]

>Пятница, 30 октября 2020, 23:02 +03:00 от Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
>
>On Fri, Oct 30, 2020 at 10:31:57AM +0300, Alexander Shiyan wrote:
>A few words about the motivation here would be great. Is 0x340000 to
>small for a current kernel? Is this following some upstream change? Why
>not install the kernel in the rootfs and get rid of the kernel
>partition?

Hello.

The current size of the kernel partition is sufficient to place i.MX51-dependent code only,
but if the kernel was compiled with support for other boards / drivers, the space is too small.
Installing the kernel in rootfs might be a good idea, but that means that rootfs is a UBIFS,
and resulting ubifs image will be NAND type dependent. In order to use the same rootfs on
different systems, I prefer to use the squashfs root filesystem on top of the UBI volume.

Let's just drop this patch.

>> Signed-off-by: Alexander Shiyan < shc_work@mail.ru >
>> ---
>> arch/arm/dts/imx51-ccxmx51.dts | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/dts/imx51-ccxmx51.dts b/arch/arm/dts/imx51-ccxmx51.dts
>> index efe5dbf63..4aa32e4c8 100644
>> --- a/arch/arm/dts/imx51-ccxmx51.dts
>> +++ b/arch/arm/dts/imx51-ccxmx51.dts
>> @@ -31,11 +31,11 @@
>>
>> partition@c0000 {
>> label = "kernel";
>> -reg = <0xc0000 0x340000>;
>> +reg = <0xc0000 0x400000>;
>> };
>>
>> -partition@400000 {
>> +partition@4c0000 {
>> label = "root";
>> -reg = <0x400000 0>;
>> +reg = <0x4c0000 0>;
>> };
>> };
>> --
>> 2.26.2

---
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] ARM: dts: CCMX51: Increase kernel partition size

[Sascha Hauer]

On Fri, Oct 30, 2020 at 10:31:57AM +0300, Alexander Shiyan wrote:
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
>  arch/arm/dts/imx51-ccxmx51.dts | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/dts/imx51-ccxmx51.dts b/arch/arm/dts/imx51-ccxmx51.dts
> index efe5dbf63..4aa32e4c8 100644
> --- a/arch/arm/dts/imx51-ccxmx51.dts
> +++ b/arch/arm/dts/imx51-ccxmx51.dts
> @@ -31,11 +31,11 @@
>  
>  	partition@c0000 {
>  		label = "kernel";
> -		reg = <0xc0000 0x340000>;
> +		reg = <0xc0000 0x400000>;
>  	};

This is an incompatible change to the partitioning, so a board won't
boot anymore when only barebox is updated. If you do the step, wouldn't
it make sense to increase the kernel partition a bit more to be future
proof for a bit longer?

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox