[PATCH] boot: drop uneeded header #includes

[PATCH] boot: drop uneeded header #includes

[Ahmad Fatoum]

Boot entry providers register themselves, so there is no need for the
common boot code to know about bootchooser or blspec or include their
headers. Remove them as well as other headers that aren't strictly
necessary and, if needed, include headers they include directly.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 common/boot.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/common/boot.c b/common/boot.c
index 76d03c26c4f4..28d3de243076 100644
--- a/common/boot.c
+++ b/common/boot.c
@@ -9,22 +9,19 @@
  * General Public License for more details.
  */
 
-#include <environment.h>
-#include <bootchooser.h>
+#include <boot.h>
 #include <globalvar.h>
 #include <magicvar.h>
 #include <watchdog.h>
 #include <command.h>
 #include <readkey.h>
 #include <common.h>
-#include <blspec.h>
 #include <libgen.h>
-#include <malloc.h>
 #include <bootm.h>
 #include <glob.h>
 #include <init.h>
 #include <menu.h>
-#include <fs.h>
+#include <unistd.h>
 
 #include <linux/stat.h>
 
-- 
2.29.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] boot: drop uneeded header #includes

[Sascha Hauer]

On Mon, Nov 23, 2020 at 03:12:39PM +0100, Ahmad Fatoum wrote:
> Boot entry providers register themselves, so there is no need for the
> common boot code to know about bootchooser or blspec or include their
> headers. Remove them as well as other headers that aren't strictly
> necessary and, if needed, include headers they include directly.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  common/boot.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/common/boot.c b/common/boot.c
> index 76d03c26c4f4..28d3de243076 100644
> --- a/common/boot.c
> +++ b/common/boot.c
> @@ -9,22 +9,19 @@
>   * General Public License for more details.
>   */
>  
> -#include <environment.h>
> -#include <bootchooser.h>
> +#include <boot.h>
>  #include <globalvar.h>
>  #include <magicvar.h>
>  #include <watchdog.h>
>  #include <command.h>
>  #include <readkey.h>
>  #include <common.h>
> -#include <blspec.h>
>  #include <libgen.h>
> -#include <malloc.h>
>  #include <bootm.h>
>  #include <glob.h>
>  #include <init.h>
>  #include <menu.h>
> -#include <fs.h>
> +#include <unistd.h>
>  
>  #include <linux/stat.h>
>  
> -- 
> 2.29.2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox