mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Roland Hieber <rhi@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>,
	barebox@lists.infradead.org,
	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
	ukl@pengutronix.de
Subject: Re: [PATCH v2 2/4] common: dummy_malloc: remove unintended GPL2 eCos-exception-2.0
Date: Sun, 29 Nov 2020 21:08:15 +0100	[thread overview]
Message-ID: <20201129200815.hrisxvxhhfgftldo@pengutronix.de> (raw)
In-Reply-To: <20201126175553.16934-2-a.fatoum@pengutronix.de>

On Thu, Nov 26, 2020 at 06:55:51PM +0100, Ahmad Fatoum wrote:
> Apparently, the file should be GPL-2.0-only without exceptions:
> 
> On 24.11.20 09:44, Sascha Hauer wrote[1]:
> > This looks like I accidently copied the wrong header. I don't think I
> > did this on purpose. It doesn't make much sense to me when compiling
> > against dummy malloc is different than compiling against tlsf malloc
> > or dlmalloc.
> 
> Ase dropping exceptions is no relicense, it's ok to do here without
> acknowledgement from all authors. Do so.

I don't understand this reasoning. The exception allowed someone to link
this file with non-GPL code, and by dropping this exception, this
possibility is no longer allowed, so there is a change in license terms.

The only two other authors of this file are Andrey and Jean-Christophe,
hereby CCed.

 - Roland
 
> [1]: <20201124084434.GC14718@pengutronix.de>
> 
> Suggested-by: Sascha Hauer <s.hauer@pengutronix.de>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> v1 -> v2: new patch
> ---
>  common/dummy_malloc.c | 21 +--------------------
>  1 file changed, 1 insertion(+), 20 deletions(-)
> 
> diff --git a/common/dummy_malloc.c b/common/dummy_malloc.c
> index 0120d9be2e85..d99b5059cf91 100644
> --- a/common/dummy_malloc.c
> +++ b/common/dummy_malloc.c
> @@ -1,25 +1,6 @@
> +// SPDX-License-Identifier: GPL-2.0-only
>  /*
>   * Copyright (C) 2013 Sascha Hauer <s.hauer@pengutronix.de>
> - *
> - * This program is free software; you can redistribute it and/or
> - * modify it under the terms of the GNU General Public License version 2
> - * as published by the Free Software Foundation.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
> - *
> - * As a special exception, if other files instantiate templates or use macros
> - * or inline functions from this file, or you compile this file and link it
> - * with other works to produce a work based on this file, this file does not
> - * by itself cause the resulting work to be covered by the GNU General Public
> - * License. However the source code for this file must still be made available
> - * in accordance with section (3) of the GNU General Public License.
> -
> - * This exception does not invalidate any other reasons why a work based on
> - * this file might be covered by the GNU General Public License.
>   */
>  #include <common.h>
>  #include <malloc.h>
> -- 
> 2.29.2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2020-11-29 20:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-26 17:55 [PATCH v2 1/4] ARM: at91: sama5d2: giantboard: fix typo in SPDX-License-Identifier Ahmad Fatoum
2020-11-26 17:55 ` [PATCH v2 2/4] common: dummy_malloc: remove unintended GPL2 eCos-exception-2.0 Ahmad Fatoum
2020-11-26 19:43   ` Uwe Kleine-König
2020-11-29 20:08   ` Roland Hieber [this message]
2020-11-29 21:17     ` Ahmad Fatoum
2020-11-26 17:55 ` [PATCH v2 3/4] LICENSES: exceptions: factor out eCos-exception-2.0 for GPL Ahmad Fatoum
2020-11-26 19:45   ` Uwe Kleine-König
2020-11-26 19:49     ` Ahmad Fatoum
2020-11-26 17:55 ` [PATCH v2 4/4] common: replace license statements with SPDX-License-Identifiers Ahmad Fatoum
2020-11-26 19:55   ` Uwe Kleine-König
2020-11-27  8:55 ` [PATCH v2 1/4] ARM: at91: sama5d2: giantboard: fix typo in SPDX-License-Identifier Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201129200815.hrisxvxhhfgftldo@pengutronix.de \
    --to=rhi@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    --cc=ukl@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox