* [PATCH] usb: host: ehci: fix mismatch in format string
@ 2020-12-01 13:17 Ahmad Fatoum
2020-12-02 11:40 ` Uwe Kleine-König
2020-12-07 7:12 ` Sascha Hauer
0 siblings, 2 replies; 3+ messages in thread
From: Ahmad Fatoum @ 2020-12-01 13:17 UTC (permalink / raw)
To: barebox; +Cc: Ahmad Fatoum
sz is of type size_t. Use the appropriate format string specifier for
print it.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
drivers/usb/host/ehci-hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
index 38999927c5a8..287849102d68 100644
--- a/drivers/usb/host/ehci-hcd.c
+++ b/drivers/usb/host/ehci-hcd.c
@@ -240,7 +240,7 @@ static int ehci_td_buffer(struct qTD *td, dma_addr_t addr, size_t sz)
}
if (idx == buffer_count) {
- pr_debug("out of buffer pointers (%u bytes left)\n", sz);
+ pr_debug("out of buffer pointers (%zu bytes left)\n", sz);
return -ENOMEM;
}
--
2.29.2
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: host: ehci: fix mismatch in format string
2020-12-01 13:17 [PATCH] usb: host: ehci: fix mismatch in format string Ahmad Fatoum
@ 2020-12-02 11:40 ` Uwe Kleine-König
2020-12-07 7:12 ` Sascha Hauer
1 sibling, 0 replies; 3+ messages in thread
From: Uwe Kleine-König @ 2020-12-02 11:40 UTC (permalink / raw)
To: Ahmad Fatoum; +Cc: barebox
[-- Attachment #1.1: Type: text/plain, Size: 414 bytes --]
On Tue, Dec 01, 2020 at 02:17:59PM +0100, Ahmad Fatoum wrote:
> sz is of type size_t. Use the appropriate format string specifier for
> print it.
I'd say this must either read "Use ... to print it" or "Use .. for
printing it".
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 149 bytes --]
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: host: ehci: fix mismatch in format string
2020-12-01 13:17 [PATCH] usb: host: ehci: fix mismatch in format string Ahmad Fatoum
2020-12-02 11:40 ` Uwe Kleine-König
@ 2020-12-07 7:12 ` Sascha Hauer
1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2020-12-07 7:12 UTC (permalink / raw)
To: Ahmad Fatoum; +Cc: barebox
On Tue, Dec 01, 2020 at 02:17:59PM +0100, Ahmad Fatoum wrote:
> sz is of type size_t. Use the appropriate format string specifier for
> print it.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> drivers/usb/host/ehci-hcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> index 38999927c5a8..287849102d68 100644
> --- a/drivers/usb/host/ehci-hcd.c
> +++ b/drivers/usb/host/ehci-hcd.c
> @@ -240,7 +240,7 @@ static int ehci_td_buffer(struct qTD *td, dma_addr_t addr, size_t sz)
> }
>
> if (idx == buffer_count) {
> - pr_debug("out of buffer pointers (%u bytes left)\n", sz);
> + pr_debug("out of buffer pointers (%zu bytes left)\n", sz);
> return -ENOMEM;
> }
>
> --
> 2.29.2
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-07 7:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-01 13:17 [PATCH] usb: host: ehci: fix mismatch in format string Ahmad Fatoum
2020-12-02 11:40 ` Uwe Kleine-König
2020-12-07 7:12 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox