mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: 郑小军 <jameszxj@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: No oob scheme defined for oobsize 224 on imx6ull board
Date: Wed, 6 Jan 2021 11:35:25 +0100	[thread overview]
Message-ID: <20210106103525.GT19063@pengutronix.de> (raw)
In-Reply-To: <CADbCKyKLBG=eSoKeqnvvGMCGdkpwNo_xGvH1D1xHHTgk0tMU1Q@mail.gmail.com>

Hi,

On Fri, Dec 18, 2020 at 05:11:11PM +0800, 郑小军 wrote:
> Hi, all
>     I am trying to run barebox on my i.mx6ull board.  I inherit from
> nxp-imx6ull-evk. When I added nand flash support, system crashed. I
> found that the pointer "chip->legacy.set_features" and
> "chip->legacy.get_features" in nand_mxs.c was NULL.
> I replaced it with nand_set_features() and nand_get_features().

This looks like the correct solution for this. Care to send a patch?

> Barebox didn't crash again, but I get the errors:
>         nand_base: device found, Manufacturer ID: 0x2c, Chip ID: 0xdc
>         nand_base: Micron MT29F4G08ABAEAWP
>         nand_base: 512 MiB, SLC, erase size: 256 KiB, page size: 4096,
> OOB size: 224
>         WARNING: at drivers/mtd/nand/nand_base.c:5591/nand_scan_tail()!
>         WARNING: No oob scheme defined for oobsize 224
>         mxs_nand 1806000.nand-controller@1806000.of: probe failed:
> Invalid argument

You are falling into:

	/*
	 * If no default placement scheme is given, select an appropriate one.
	 */
	if (!mtd->ooblayout &&
	    !(ecc->mode == NAND_ECC_SOFT && ecc->algo == NAND_ECC_BCH)) {
			...
	}

Normally mtd->ooblayout should be set at this point. the nand_mxs driver
currently misses to set it. I think you have to adopt
gpmi_ooblayout_ecc() and gpmi_ooblayout_free() from the Linux driver for
barebox.

This bug seems to trigger for NANDs with bigger page sizes. I only
tested the last NAND layer update with smaller page sizes. So it's not
you who misses something, it's me who missed something ;)

Regards,
  Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2021-01-06 10:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-18  9:11 郑小军
2021-01-06 10:35 ` Sascha Hauer [this message]
2021-01-07  2:27   ` =?gb18030?B?amFtZXN6eGo=?=
     [not found]   ` <tencent_38A3D28635D0E3DF1085571FDB818F5D420A@qq.com>
2021-02-23  0:21     ` =?gb18030?B?amFtZXN6eGo=?=
2021-02-23  7:51     ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210106103525.GT19063@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=jameszxj@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox