From: Marco Felsch <m.felsch@pengutronix.de>
To: Sascha Hauer <sha@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] blspec: allow board files to overwrite config file settings
Date: Tue, 19 Jan 2021 12:42:08 +0100 [thread overview]
Message-ID: <20210119114208.6kxdsj5pa5zo25qo@pengutronix.de> (raw)
In-Reply-To: <20210119110134.GX19063@pengutronix.de>
Hi Sascha,
On 21-01-19 12:01, Sascha Hauer wrote:
> Hi Marco,
> On Mon, Jan 18, 2021 at 09:48:49PM +0100, Marco Felsch wrote:
> > This commit adds the support to overwrite and/or adapt blspec config
> > files by the following global variables:
> > - global.blspec.fixup.devicetree
> > - global.blspec.fixup.initrd
> > - global.blspec.fixup.options
> > - global.blspec.fixup.linux
> > - global.blspec.fixup.devicetree-overlay.
> >
> > Overwriting blspec-config's shouldn't be the normal case but there are
> > cases where this support is needed. One use-case can be a special
> > handling during update. E.g. the normal boot-flow don't need the initrd
> > but the update-flow uses it because the update system is on the initrd.
>
> When you have an update system and a regular system on the same
> filesystem then I would expect an additional bootspec entry for the
> update system.
AFAIK, barebox tries to find the correct entry by checking all config
files and loads the first matching config file. Is there a way to
specify an explicite config file?
> > Another use-case could be a dynamic devicetree-overlay handling. E.g.
> > the board code dynamically checks which periphery boards are connected
> > and adds the required overlays dynamically.
>
> Board code can register overlays already, there's no need for bootspec
> to do that.
But this needs a lot more handling if we boot from nfs or from emmc.
Therefore I utilized the already existing code :)
> Overall overwriting bootspec variables somewhat contradicts the whole
> purpose of bootspec. I don't like that very much, so you'll need very
> good reasons to get this through ;)
Yep, I thought so ;) Therefore I wrote a big warning. It gives you a lot
opportunities to shot yourself in the foot. Therefore I print a warning
if you overwrite a already exisiting config.
Regards,
Marco
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2021-01-19 11:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 20:48 Marco Felsch
2021-01-18 20:48 ` [PATCH 2/2] Documentation: blspec: Add blspec fixup documentation Marco Felsch
2021-01-19 11:01 ` [PATCH 1/2] blspec: allow board files to overwrite config file settings Sascha Hauer
2021-01-19 11:42 ` Marco Felsch [this message]
2021-01-20 9:03 ` Sascha Hauer
2021-01-20 10:54 ` Marco Felsch
2021-01-20 12:31 ` Michael Olbrich
2021-01-20 13:26 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210119114208.6kxdsj5pa5zo25qo@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=sha@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox