From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/4] treewide: include <linux/math64.h> wrapper instead of <asm-generic/div64.h>
Date: Thu, 18 Feb 2021 10:24:53 +0100 [thread overview]
Message-ID: <20210218092453.GC4207@pengutronix.de> (raw)
In-Reply-To: <20210216185737.10621-1-a.fatoum@pengutronix.de>
On Tue, Feb 16, 2021 at 07:57:34PM +0100, Ahmad Fatoum wrote:
> <asm-generic/div64.h> isn't meant for direct usage as <asm/div64.h> may
> override this on a per-architecture basis. We don't do that currently,
> but in the future we might. Include the <linux/math64.h> instead.
>
> No functional change.
This breaks rk3188_defconfig:
config: arm rk3188_defconfig
In file included from drivers/clk/rockchip/clk-pll.c:7:
include/linux/math64.h:303:8: error: unknown type name '__always_inline'
303 | static __always_inline u32
| ^~~~~~~~~~~~~~~
include/linux/math64.h:304:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__iter_div_u64_rem'
304 | __iter_div_u64_rem(u64 dividend, u32 divisor, u64 *remainder)
| ^~~~~~~~~~~~~~~~~~
make[3]: *** [/ptx/work/WORK_EIHEI/sha/backup/barebox/barebox-maintainer-utils/barebox/scripts/Makefile.build:141: drivers/clk/rockchip/clk-pll.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [/ptx/work/WORK_EIHEI/sha/backup/barebox/barebox-maintainer-utils/barebox/scripts/Makefile.build:275: drivers/clk/rockchip] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/ptx/work/WORK_EIHEI/sha/backup/barebox/barebox-maintainer-utils/barebox/scripts/Makefile.build:275: drivers/clk] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:925: drivers] Error 2
make: *** Waiting for unfinished jobs....
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2021-02-18 9:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 18:57 Ahmad Fatoum
2021-02-16 18:57 ` [PATCH 2/4] include: asm-generic: don't do 64-bit soft division on 64-bit platforms Ahmad Fatoum
2021-02-16 18:57 ` [PATCH 3/4] lib: remove duplicate __div64_32 Ahmad Fatoum
2021-02-16 18:57 ` [PATCH 4/4] drivers: replaces references to <asm-generic/*.h> Ahmad Fatoum
2021-02-18 8:25 ` [PATCH 1/4] treewide: include <linux/math64.h> wrapper instead of <asm-generic/div64.h> Sascha Hauer
2021-02-18 9:24 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210218092453.GC4207@pengutronix.de \
--to=sha@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox