From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 05 Mar 2021 11:56:59 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1lI88h-0002YM-Br for lore@lore.pengutronix.de; Fri, 05 Mar 2021 11:56:59 +0100 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lI88f-0000ct-QQ for lore@pengutronix.de; Fri, 05 Mar 2021 11:56:58 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Dg3/1jEWlSHB1VY3P/nDWgFUefxSDCKOR+zVnXm2+Rw=; b=SHsx+f8HMHPIeh RzuN5u2FJKzp5S8+kyRmHhttnWE+2ac2uto+0XYAAcqncZunxRXzgGi+jjla5e/sd0bCa+sALdBxn dQD2j8P6o9DKJQgNBgN60difZCWpFl9TyOq7HCq5LzBFk8eueFDYXOApJmv7nZiS0AYkCo2A6a0Be hrTAQgPrAcDtH3sbBUqY9egfwZB5EhowMhs+PTJ5xtAAWybS7JLkt3gTZxPmUS/cJFa4wodh/RZa1 JTBheMRh+wUSDQdMLb2MrRDI6givi6pyowIozHu/hmvWFKc7fdDS+fyweyLS7mQFoTUKdRffAADIT PRLqEt7ZWxECxI++BXrQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lI879-00EeE5-OP; Fri, 05 Mar 2021 10:55:24 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lI86W-00EeA9-Am for barebox@lists.infradead.org; Fri, 05 Mar 2021 10:54:48 +0000 Received: from dude02.hi.pengutronix.de ([2001:67c:670:100:1d::28]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lI86V-0000IS-QL; Fri, 05 Mar 2021 11:54:43 +0100 Received: from sha by dude02.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1lI86V-0007kq-GZ; Fri, 05 Mar 2021 11:54:43 +0100 From: Sascha Hauer To: Barebox List Date: Fri, 5 Mar 2021 11:54:42 +0100 Message-Id: <20210305105442.28393-1-s.hauer@pengutronix.de> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210305_105447_031098_D5962DC4 X-CRM114-Status: GOOD ( 11.07 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" X-SA-Exim-Connect-IP: 2001:8b0:10b:1:d65d:64ff:fe57:4e05 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-3.5 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH] printk: fix inverted logic in print_hex_dump_debug() X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) print_hex_dump_debug() shall print a hexdump when debugging is enabled, not when it's disabled. Fixes: 5825231429 ("printk: port over Linux print_hex_dump_bytes/print_hex_dump_debug") Signed-off-by: Sascha Hauer --- include/printk.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/printk.h b/include/printk.h index f92e477298..94a25ec9eb 100644 --- a/include/printk.h +++ b/include/printk.h @@ -160,7 +160,7 @@ extern void print_hex_dump(const char *level, const char *prefix_str, int prefix_type, int rowsize, int groupsize, const void *buf, size_t len, bool ascii); -#if LOGLEVEL <= MSG_DEBUG +#if LOGLEVEL >= MSG_DEBUG #define print_hex_dump_debug(prefix_str, prefix_type, rowsize, \ groupsize, buf, len, ascii) \ print_hex_dump(KERN_DEBUG, prefix_str, prefix_type, rowsize, \ -- 2.29.2 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox