mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Denis Osterland-Heim <denis.osterland@diehl.com>
To: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: [PATCH] image-fit: ignore rsa by image selection
Date: Thu, 11 Mar 2021 17:07:21 +0000	[thread overview]
Message-ID: <20210311170334.22607-1-denis.osterland@diehl.com> (raw)

From: Denis Osterland-Heim <Denis.Osterland@diehl.com>

For hash algorithm selection, only the first argument of the tuple is
needed. The ',' is included to avoid false-positive matches.

Signed-off-by: Denis Osterland-Heim <Denis.Osterland@diehl.com>
---
 common/image-fit.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/common/image-fit.c b/common/image-fit.c
index 538e61f51..2c5ef7f68 100644
--- a/common/image-fit.c
+++ b/common/image-fit.c
@@ -230,11 +230,9 @@ static struct digest *fit_alloc_digest(struct device_node *sig_node,
 return ERR_PTR(-EINVAL);
 }

-if (strcmp(algo_name, "sha1,rsa2048") == 0) {
+if (strncmp(algo_name, "sha1,", 5) == 0) {
 algo = HASH_ALGO_SHA1;
-} else if (strcmp(algo_name, "sha256,rsa2048") == 0) {
-algo = HASH_ALGO_SHA256;
-} else if (strcmp(algo_name, "sha256,rsa4096") == 0) {
+} else if (strncmp(algo_name, "sha256,", 7) == 0) {
 algo = HASH_ALGO_SHA256;
 } else{
 pr_err("unknown algo %s\n", algo_name);
--
2.30.2

Diehl Connectivity Solutions GmbH
Geschäftsführung: Horst Leonberger
Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
Nürnberg: HRB 32315

________________________________

Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.

- Informationen zum Datenschutz, insbesondere zu Ihren Rechten, erhalten Sie unter:

https://www.diehl.com/group/de/transparenz-und-informationspflichten/

The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited.

- For general information on data protection and your respective rights please visit:

https://www.diehl.com/group/en/transparency-and-information-obligations/



_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


             reply	other threads:[~2021-03-11 17:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-11 17:07 Denis Osterland-Heim [this message]
2021-03-15  8:46 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210311170334.22607-1-denis.osterland@diehl.com \
    --to=denis.osterland@diehl.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox