From: Jules Maselbas <jmaselbas@kalray.eu>
To: barebox@lists.infradead.org
Cc: Jules Maselbas <jmaselbas@kalray.eu>
Subject: [PATCH 2/5] usb: dwc2: Replace pr_info with dev_warn
Date: Fri, 12 Mar 2021 17:24:29 +0100 [thread overview]
Message-ID: <20210312162432.9189-2-jmaselbas@kalray.eu> (raw)
In-Reply-To: <20210312162432.9189-1-jmaselbas@kalray.eu>
There is no reason to not use dev_warn (as done in Linux), this might
have been unwanted changes made when porting the driver to barebox.
Signed-off-by: Jules Maselbas <jmaselbas@kalray.eu>
---
drivers/usb/dwc2/core.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c
index cc5729ed9..8ec77d68a 100644
--- a/drivers/usb/dwc2/core.c
+++ b/drivers/usb/dwc2/core.c
@@ -696,8 +696,8 @@ int dwc2_core_reset(struct dwc2 *dwc2)
/* Wait for AHB master IDLE state. */
ret = dwc2_wait_bit_set(dwc2, GRSTCTL, GRSTCTL_AHBIDLE, 10000);
if (ret) {
- pr_info("%s: Timeout! Waiting for AHB master IDLE state\n",
- __func__);
+ dwc2_warn(dwc2, "%s: Timeout! Waiting for AHB master IDLE state\n",
+ __func__);
return ret;
}
@@ -728,7 +728,8 @@ int dwc2_core_reset(struct dwc2 *dwc2)
ret = dwc2_wait_bit_clear(dwc2, GRSTCTL, GRSTCTL_CSFTRST, 10000);
if (ret) {
- pr_info("%s: Timeout! Waiting for Core Soft Reset\n", __func__);
+ dwc2_warn(dwc2, "%s: Timeout! Waiting for Core Soft Reset\n",
+ __func__);
return ret;
}
--
2.17.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2021-03-12 16:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 16:24 [PATCH 1/5] usb: dwc2: Make dwc2_wait_bit_set wait all bits in mask Jules Maselbas
2021-03-12 16:24 ` Jules Maselbas [this message]
2021-03-12 16:24 ` [PATCH 3/5] usb: dwc2: Rework dwc2_wait_for_mode to use wait_on_timeout Jules Maselbas
2021-03-12 16:24 ` [PATCH 4/5] usb: dwc2: Move wait_for_mode and iddig_filter_enabled to core Jules Maselbas
2021-03-12 16:24 ` [PATCH 5/5] usb: dwc2: Rework wait for host mode during core reset Jules Maselbas
2021-03-15 8:51 ` [PATCH 1/5] usb: dwc2: Make dwc2_wait_bit_set wait all bits in mask Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210312162432.9189-2-jmaselbas@kalray.eu \
--to=jmaselbas@kalray.eu \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox