mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH master] ARM: mmu64: fix build for non-MMU configurations
Date: Mon, 15 Mar 2021 08:50:03 +0100	[thread overview]
Message-ID: <20210315075003.GE23724@pengutronix.de> (raw)
In-Reply-To: <20210311103654.7729-1-a.fatoum@pengutronix.de>

On Thu, Mar 11, 2021 at 11:36:54AM +0100, Ahmad Fatoum wrote:
> barebox only catches null pointer dereferences when MMU support is
> enabled. Thus the empty stubs should always be used on !CONFIG_MMU
> systems, disregarding whether CONFIG_ARCH_HAS_ZERO_PAGE is selected
> or not.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  include/zero_page.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/include/zero_page.h b/include/zero_page.h
> index ad6861f240c6..519e65be7628 100644
> --- a/include/zero_page.h
> +++ b/include/zero_page.h
> @@ -4,7 +4,7 @@
>  
>  #include <common.h>
>  
> -#if defined CONFIG_ARCH_HAS_ZERO_PAGE
> +#if defined CONFIG_ARCH_HAS_ZERO_PAGE && defined CONFIG_MMU
>  
>  /*
>   * zero_page_faulting - fault when accessing the zero page
> -- 
> 2.29.2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


      reply	other threads:[~2021-03-15  7:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-11 10:36 Ahmad Fatoum
2021-03-15  7:50 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210315075003.GE23724@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox