mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH master] of: base: probe simple-pm-bus children as well
Date: Mon, 15 Mar 2021 09:05:09 +0100	[thread overview]
Message-ID: <20210315080509.GG23724@pengutronix.de> (raw)
In-Reply-To: <20210312082218.17058-1-a.fatoum@pengutronix.de>

On Fri, Mar 12, 2021 at 09:22:18AM +0100, Ahmad Fatoum wrote:
> Upstream is migrating device trees like those of the am33xx to use
> simple-pm-bus, where applicable. These are buses that reference a clock
> or a power domain that needs to be enabled in order to use devices on it.
> 
> As we didn't yet support this binding, this broke the Beaglebone
> and all other am33xx board since v2021.02.0.
> 
> Fix this by adding simple-pm-bus to the of_default_bus_match_table.
> Note that this is only an adequate solution for when the power domain
> and clocks referenced are already enabled prior to barebox startup.
> 
> For all other cases, driver support must be available for the clock
> and power domains in questions and this driver must be extended to
> make use of them. For the am33xx, the relevant buses are powered
> and clocked on boot up, so we leave general support to another day..
> 
> Fixes: 6ea3de1b8ce7 ("dts: update to v5.11-rc1")
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  drivers/of/base.c | 2 ++
>  1 file changed, 2 insertions(+)

Applied, thanks

Sascha

> 
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index 8759099d7480..6fe02649ee53 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -2272,6 +2272,8 @@ const char *of_get_model(void)
>  const struct of_device_id of_default_bus_match_table[] = {
>  	{
>  		.compatible = "simple-bus",
> +	}, {
> +		.compatible = "simple-pm-bus",
>  	}, {
>  		.compatible = "simple-mfd",
>  	}, {
> -- 
> 2.29.2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


      reply	other threads:[~2021-03-15  8:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-12  8:22 Ahmad Fatoum
2021-03-15  8:05 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210315080509.GG23724@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox