From: Sascha Hauer <sha@pengutronix.de>
To: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] scripts: imx-image: add error handling for pwrite
Date: Mon, 15 Mar 2021 09:06:07 +0100 [thread overview]
Message-ID: <20210315080607.GH23724@pengutronix.de> (raw)
In-Reply-To: <20210312105444.22838-1-r.czerwinski@pengutronix.de>
On Fri, Mar 12, 2021 at 11:54:44AM +0100, Rouven Czerwinski wrote:
> Fixes the following compiler warning:
>
> scripts/imx/imx-image.c: In function ‘main’:
> scripts/imx/imx-image.c:988:3: warning: ignoring return value of ‘pwrite’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 988 | pwrite(outfd, bb_header, sizeof_bb_header, 0);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> ---
> scripts/imx/imx-image.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/scripts/imx/imx-image.c b/scripts/imx/imx-image.c
> index f5e89d07a6..57d777a065 100644
> --- a/scripts/imx/imx-image.c
> +++ b/scripts/imx/imx-image.c
> @@ -984,8 +984,13 @@ int main(int argc, char *argv[])
> xwrite(outfd, buf, header_len);
> }
>
> - if (add_barebox_header)
> - pwrite(outfd, bb_header, sizeof_bb_header, 0);
> + if (add_barebox_header) {
> + ret = pwrite(outfd, bb_header, sizeof_bb_header, 0);
> + if (ret < 0) {
> + fprintf(stderr, "pwrite failed: %s\n", strerror(errno));
> + exit(1);
> + }
> + }
>
> xwrite(outfd, infile, insize);
>
> --
> 2.30.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2021-03-15 8:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 10:54 Rouven Czerwinski
2021-03-15 8:06 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315080607.GH23724@pengutronix.de \
--to=sha@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=r.czerwinski@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox