From: Sascha Hauer <sha@pengutronix.de>
To: Jules Maselbas <jmaselbas@kalray.eu>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC PATCH] reset: Remove WARN_ON when CONFIG_RESET_CONTROLLER=n
Date: Mon, 15 Mar 2021 10:35:37 +0100 [thread overview]
Message-ID: <20210315093537.GR23724@pengutronix.de> (raw)
In-Reply-To: <20210312152145.2761-1-jmaselbas@kalray.eu>
On Fri, Mar 12, 2021 at 04:21:45PM +0100, Jules Maselbas wrote:
> Signed-off-by: Jules Maselbas <jmaselbas@kalray.eu>
> ---
> I am using dwc2 but my platform doesn't has CONFIG_RESET_CONTROLLER enabled,
> when booting barebox I got this kind of message:
> WARNING: at barebox/include/linux/reset.h:54/device_reset_us()!
>
> Not sure if removing all the WARN_ON is a good idea... asking for insight.
I looked at the kernel and it has no warnings in the stubs. For that
reason I applied this patch.
Having no warnings has its downside as well of course. If you really
need resets for your device to function then you won't notice that reset
support is missing.
Sascha
> ---
> include/linux/reset.h | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/include/linux/reset.h b/include/linux/reset.h
> index 4a92a177b..a166fe1cf 100644
> --- a/include/linux/reset.h
> +++ b/include/linux/reset.h
> @@ -21,43 +21,36 @@ int __must_check device_reset_us(struct device_d *dev, int us);
>
> static inline int reset_control_reset(struct reset_control *rstc)
> {
> - WARN_ON(1);
> return 0;
> }
>
> static inline int reset_control_assert(struct reset_control *rstc)
> {
> - WARN_ON(1);
> return 0;
> }
>
> static inline int reset_control_deassert(struct reset_control *rstc)
> {
> - WARN_ON(1);
> return 0;
> }
>
> static inline struct reset_control *
> reset_control_get(struct device_d *dev, const char *id)
> {
> - WARN_ON(1);
> return NULL;
> }
>
> static inline void reset_control_put(struct reset_control *rstc)
> {
> - WARN_ON(1);
> }
>
> static inline int device_reset_us(struct device_d *dev, int us)
> {
> - WARN_ON(1);
> return 0;
> }
>
> static inline int device_reset(struct device_d *dev)
> {
> - WARN_ON(1);
> return 0;
> }
>
> --
> 2.17.1
>
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2021-03-15 9:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 15:21 Jules Maselbas
2021-03-15 9:35 ` Sascha Hauer [this message]
2021-03-15 11:03 ` Jules Maselbas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315093537.GR23724@pengutronix.de \
--to=sha@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=jmaselbas@kalray.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox