mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Jules Maselbas <jmaselbas@kalray.eu>
To: Sascha Hauer <sha@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC PATCH] reset: Remove WARN_ON when CONFIG_RESET_CONTROLLER=n
Date: Mon, 15 Mar 2021 12:03:33 +0100	[thread overview]
Message-ID: <20210315110333.GA20207@tellis.lin.mbt.kalray.eu> (raw)
In-Reply-To: <20210315093537.GR23724@pengutronix.de>

On Mon, Mar 15, 2021 at 10:35:37AM +0100, Sascha Hauer wrote:
> On Fri, Mar 12, 2021 at 04:21:45PM +0100, Jules Maselbas wrote:
> > Signed-off-by: Jules Maselbas <jmaselbas@kalray.eu>
> > ---
> > I am using dwc2 but my platform doesn't has CONFIG_RESET_CONTROLLER enabled,
> > when booting barebox I got this kind of message:
> > WARNING: at barebox/include/linux/reset.h:54/device_reset_us()!
> > 
> > Not sure if removing all the WARN_ON is a good idea... asking for insight.
> 
> I looked at the kernel and it has no warnings in the stubs. For that
> reason I applied this patch.
> 
> Having no warnings has its downside as well of course. If you really
> need resets for your device to function then you won't notice that reset
> support is missing.
Yeah, that makes me a bit unconfortable with removing all WARN_ON.
I though to only warn if the function is call and the device has an
"reset" in it's of_tree node. But then it's no longer a stub.



_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


      reply	other threads:[~2021-03-15 11:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-12 15:21 Jules Maselbas
2021-03-15  9:35 ` Sascha Hauer
2021-03-15 11:03   ` Jules Maselbas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210315110333.GA20207@tellis.lin.mbt.kalray.eu \
    --to=jmaselbas@kalray.eu \
    --cc=barebox@lists.infradead.org \
    --cc=sha@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox