[PATCH] mtd: Notify user when erasure of a block failed during erase op

[PATCH] mtd: Notify user when erasure of a block failed during erase op

[Stefan Riedmueller]

Give the user information about the faulty block when an erase
operation fails with error.

Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de>
---
 drivers/mtd/core.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/mtd/core.c b/drivers/mtd/core.c
index af33ad665c5a..22eb2a056c4e 100644
--- a/drivers/mtd/core.c
+++ b/drivers/mtd/core.c
@@ -222,8 +222,11 @@ static int mtd_op_erase(struct cdev *cdev, loff_t count, loff_t offset)
 			printf("Skipping bad block at 0x%08llx\n", addr);
 		} else {
 			ret = mtd_erase(mtd, &erase);
-			if (ret)
+			if (ret) {
+				printf("%s: failed to erase block at 0x%08llx\n",
+					__func__, addr);
 				return ret;
+			}
 		}
 
 		addr += mtd->erasesize;
-- 
2.25.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] mtd: Notify user when erasure of a block failed during erase op

[Sascha Hauer]

On Tue, Mar 16, 2021 at 01:44:20PM +0100, Stefan Riedmueller wrote:
> Give the user information about the faulty block when an erase
> operation fails with error.
> 
> Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de>
> ---
>  drivers/mtd/core.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/mtd/core.c b/drivers/mtd/core.c
> index af33ad665c5a..22eb2a056c4e 100644
> --- a/drivers/mtd/core.c
> +++ b/drivers/mtd/core.c
> @@ -222,8 +222,11 @@ static int mtd_op_erase(struct cdev *cdev, loff_t count, loff_t offset)
>  			printf("Skipping bad block at 0x%08llx\n", addr);
>  		} else {
>  			ret = mtd_erase(mtd, &erase);
> -			if (ret)
> +			if (ret) {
> +				printf("%s: failed to erase block at 0x%08llx\n",
> +					__func__, addr);
>  				return ret;
> +			}
>  		}
>  
>  		addr += mtd->erasesize;
> -- 
> 2.25.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox