From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <ahmad@a3f.at>
Cc: barebox@lists.infradead.org, rcz@pengutronix.de
Subject: Re: [PATCH 0/8] <asm/setjmp.h>: Don't use __noreturn without header
Date: Wed, 17 Mar 2021 11:56:05 +0100 [thread overview]
Message-ID: <20210317105605.GB23724@pengutronix.de> (raw)
In-Reply-To: <20210317104643.2058151-1-ahmad@a3f.at>
On Wed, Mar 17, 2021 at 11:46:35AM +0100, Ahmad Fatoum wrote:
> __noreturn is defined in <linux/compiler.h>, which isn't included in
> every <asm/setjmp>, so arm32 that uses setjmp outside of bthreads fails
> to build. In order to keep changes to a minimum, just replace
> __noreturn with __attribute__((noreturn))
>
> Tested on:
> arm32, aarch64, mipsel, mips, riscv32, riscv64
>
> Ahmad Fatoum (8):
> fixup! ARM: asm: setjmp: implement coroutine dependency initjmp()
> fixup! kvx: Implement setjmp/longjmp/initjmp
> fixup! mips: Implement setjmp/longjmp/initjmp for 32BIT
> fixup! openrisc: Implement setjmp/longjmp/initjmp
> fixup! powerpc: Implement initjmp/setjmp/longjmp
> fixup! riscv: Implement setjmp/longjmp/initjmp for RV32I
> fixup! sandbox: asm: implement setjmp/longjmp/initjmp
> fixup! x86: implement setjmp/longjmp/initjmp
Applied, thanks
Sascha
>
> arch/arm/include/asm/setjmp.h | 2 +-
> arch/kvx/include/asm/setjmp.h | 2 +-
> arch/mips/include/asm/setjmp.h | 2 +-
> arch/openrisc/include/asm/setjmp.h | 2 +-
> arch/powerpc/include/asm/setjmp.h | 2 +-
> arch/riscv/include/asm/setjmp.h | 2 +-
> arch/sandbox/include/asm/setjmp.h | 2 +-
> arch/x86/include/asm/setjmp.h | 2 +-
> 8 files changed, 8 insertions(+), 8 deletions(-)
>
> --
> 2.30.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2021-03-17 10:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 10:46 Ahmad Fatoum
2021-03-17 10:46 ` [PATCH 1/8] fixup! ARM: asm: setjmp: implement coroutine dependency initjmp() Ahmad Fatoum
2021-03-17 10:46 ` [PATCH 2/8] fixup! kvx: Implement setjmp/longjmp/initjmp Ahmad Fatoum
2021-03-17 10:46 ` [PATCH 3/8] fixup! mips: Implement setjmp/longjmp/initjmp for 32BIT Ahmad Fatoum
2021-03-17 10:46 ` [PATCH 4/8] fixup! openrisc: Implement setjmp/longjmp/initjmp Ahmad Fatoum
2021-03-17 10:46 ` [PATCH 5/8] fixup! powerpc: Implement initjmp/setjmp/longjmp Ahmad Fatoum
2021-03-17 10:46 ` [PATCH 6/8] fixup! riscv: Implement setjmp/longjmp/initjmp for RV32I Ahmad Fatoum
2021-03-17 10:46 ` [PATCH 7/8] fixup! sandbox: asm: implement setjmp/longjmp/initjmp Ahmad Fatoum
2021-03-17 10:46 ` [PATCH 8/8] fixup! x86: " Ahmad Fatoum
2021-03-17 10:56 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210317105605.GB23724@pengutronix.de \
--to=sha@pengutronix.de \
--cc=ahmad@a3f.at \
--cc=barebox@lists.infradead.org \
--cc=rcz@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox