[PATCH] gpio: pl061: implement gpio_ops::get_direction

[PATCH] gpio: pl061: implement gpio_ops::get_direction

[Ahmad Fatoum]

This makes gpioinfo on board that incorporate it more useful.

Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
---
 drivers/gpio/gpio-pl061.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/gpio/gpio-pl061.c b/drivers/gpio/gpio-pl061.c
index b9a8846dedaa..8dd9ca3bd5cd 100644
--- a/drivers/gpio/gpio-pl061.c
+++ b/drivers/gpio/gpio-pl061.c
@@ -84,7 +84,18 @@ static void pl061_set_value(struct gpio_chip *gc, unsigned offset, int value)
 	writeb(!!value << offset, chip->base + (1 << (offset + 2)));
 }
 
+static int pl061_get_direction(struct gpio_chip *gc, unsigned offset)
+{
+	struct pl061_gpio *chip = container_of(gc, struct pl061_gpio, gc);
+
+	if (readb(chip->base + GPIODIR) & (1 << offset))
+		return GPIOF_DIR_OUT;
+
+	return GPIOF_DIR_IN;
+}
+
 static struct gpio_ops pl061_gpio_ops = {
+	.get_direction = pl061_get_direction,
 	.direction_input = pl061_direction_input,
 	.direction_output = pl061_direction_output,
 	.get = pl061_get_value,
-- 
2.30.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] gpio: pl061: implement gpio_ops::get_direction

[Sascha Hauer]

On Sat, Apr 10, 2021 at 12:51:10PM +0200, Ahmad Fatoum wrote:
> This makes gpioinfo on board that incorporate it more useful.
> 
> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
> ---
>  drivers/gpio/gpio-pl061.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)

Applied, thanks

Sascha

> 
> diff --git a/drivers/gpio/gpio-pl061.c b/drivers/gpio/gpio-pl061.c
> index b9a8846dedaa..8dd9ca3bd5cd 100644
> --- a/drivers/gpio/gpio-pl061.c
> +++ b/drivers/gpio/gpio-pl061.c
> @@ -84,7 +84,18 @@ static void pl061_set_value(struct gpio_chip *gc, unsigned offset, int value)
>  	writeb(!!value << offset, chip->base + (1 << (offset + 2)));
>  }
>  
> +static int pl061_get_direction(struct gpio_chip *gc, unsigned offset)
> +{
> +	struct pl061_gpio *chip = container_of(gc, struct pl061_gpio, gc);
> +
> +	if (readb(chip->base + GPIODIR) & (1 << offset))
> +		return GPIOF_DIR_OUT;
> +
> +	return GPIOF_DIR_IN;
> +}
> +
>  static struct gpio_ops pl061_gpio_ops = {
> +	.get_direction = pl061_get_direction,
>  	.direction_input = pl061_direction_input,
>  	.direction_output = pl061_direction_output,
>  	.get = pl061_get_value,
> -- 
> 2.30.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox