mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Lars Pedersen <lapeddk@gmail.com>
Cc: barebox@lists.infradead.org, Bruno Thomsen <bruno.thomsen@gmail.com>
Subject: Re: [PATCH] ARM: i.MX: Fix Kamstrup mx7 concentrator default cfg
Date: Tue, 13 Apr 2021 15:40:48 +0200	[thread overview]
Message-ID: <20210413134048.GO19819@pengutronix.de> (raw)
In-Reply-To: <20210413092340.241337-1-lapeddk@gmail.com>

Hi Lars,

On Tue, Apr 13, 2021 at 11:23:40AM +0200, Lars Pedersen wrote:
> Select CONFIG_POWER_RESET_GPIO_RESTART for Kamstrup mx7 concentrator
> board.
> 
> Signed-off-by: Lars Pedersen <lapeddk@gmail.com>
> Reviewed-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> ---
> Requires patch ARM: i.MX: Kamstrup mx7 concentrator board support
> 
>  arch/arm/mach-imx/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index cc73d0a0d..4ee8ffe4b 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -530,6 +530,7 @@ config MACH_KAMSTRUP_MX7_CONCENTRATOR
>  	bool "Kamstrup i.MX7 Concentrator"
>  	select ARCH_IMX7
>  	select ARM_USE_COMPRESSED_DTB
> +	select CONFIG_POWER_RESET_GPIO_RESTART

I wouldn't select it. CONFIG_POWER_RESET_GPIO_RESTART depends on other
options and Kconfig can't automatically select the dependencies.

Also if you don't want to make use of the gpio restart driver then you
don't want to be forced to compile it in.

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


  parent reply	other threads:[~2021-04-13 13:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-13  6:17 [PATCH v2] ARM: i.MX: Kamstrup mx7 concentrator board support Lars Pedersen
2021-04-13  6:26 ` Ahmad Fatoum
2021-04-13  9:23 ` [PATCH] ARM: i.MX: Fix Kamstrup mx7 concentrator default cfg Lars Pedersen
2021-04-13 10:09   ` Ahmad Fatoum
2021-04-13 11:03     ` Lars Pedersen
2021-04-13 11:07       ` Ahmad Fatoum
2021-04-13 13:31         ` Lars Pedersen
2021-04-13 13:38   ` [PATCH v2] " Lars Pedersen
2021-04-13 13:40   ` Sascha Hauer [this message]
2021-04-13 15:04     ` [PATCH] " Ahmad Fatoum
2021-04-14  7:08       ` Sascha Hauer
2021-04-14  7:15         ` Ahmad Fatoum
2021-04-14  7:51           ` Sascha Hauer
2021-04-14 14:37 ` [PATCH v2] ARM: i.MX: Kamstrup mx7 concentrator board support Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210413134048.GO19819@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=bruno.thomsen@gmail.com \
    --cc=lapeddk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox