mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Lucas Stach <>
Subject: [PATCH v2 1/2] uncompress: use read_full to fill decompression buffer
Date: Wed, 26 May 2021 11:02:15 +0200	[thread overview]
Message-ID: <> (raw)

The decompression algorithms want all of the requested buffer size
to be filled and don't cope with less bytes being returned.
Use read_full to satisfy this requirement.

Signed-off-by: Lucas Stach <>
 lib/uncompress.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/uncompress.c b/lib/uncompress.c
index c47d319dbb5f..5c0d1e9f4d66 100644
--- a/lib/uncompress.c
+++ b/lib/uncompress.c
@@ -24,6 +24,7 @@
 #include <filetype.h>
 #include <malloc.h>
 #include <fs.h>
+#include <libfile.h>
 static void *uncompress_buf;
 static unsigned int uncompress_size;
@@ -142,7 +143,7 @@ static int uncompress_infd, uncompress_outfd;
 static int fill_fd(void *buf, unsigned int len)
-	return read(uncompress_infd, buf, len);
+	return read_full(uncompress_infd, buf, len);
 static int flush_fd(void *buf, unsigned int len)

barebox mailing list

             reply	other threads:[~2021-05-26  9:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26  9:02 Lucas Stach [this message]
2021-05-26  9:02 ` [PATCH v2 2/2] bootm: add support for booting compressed images Lucas Stach
2021-05-28  7:06   ` Ahmad Fatoum
2021-05-27  6:50 ` [PATCH v2 1/2] uncompress: use read_full to fill decompression buffer Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox