From: Sascha Hauer <sha@pengutronix.de>
To: Trent Piepho <tpiepho@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] mtd: nand: Add help text for i.MX NAND controllers
Date: Thu, 27 May 2021 09:16:28 +0200 [thread overview]
Message-ID: <20210527071628.GD19819@pengutronix.de> (raw)
In-Reply-To: <20210526064805.367434-1-trent.piepho@igorinstitute.com>
Hi Trent,
On Tue, May 25, 2021 at 11:48:05PM -0700, Trent Piepho wrote:
> From: Trent Piepho <tpiepho@gmail.com>
>
> There are two different NAND drivers, used for different chips in the
> i.MX range. It's quite confusing as to which to use. Add some help
> text to clarify.
>
> Signed-off-by: Trent Piepho <tpiepho@gmail.com>
> ---
> drivers/mtd/nand/Kconfig | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index 7c9326089..9dd6851f3 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -32,14 +32,25 @@ config NAND_ALLOW_ERASE_BAD
>
> config NAND_IMX
> bool
> - prompt "i.MX NAND driver"
> + prompt "i.MX NAND driver aka 'mxc'"
> depends on ARCH_IMX
> + help
> + Support for NAND flash on Freescale/NXP i.MX devices. This is for the
> + "MXC" series: i.MX21/25/27/31/35/51/53. It is not for the "MXS"
> + series i.MX processors (23 & 28), or i.MX6 and later, which use the
> + NAND controller from the MSX processors. See the i.MX 'mxs' driver
s/MSX/MXS/
> + for those chips.
>
> config NAND_MXS
> bool
> select STMP_DEVICE
> - prompt "i.MX23/28/6 NAND driver"
> + prompt "i.MX23/28 & 6+ NAND driver aka 'mxs'"
> depends on MXS_APBH_DMA
> + help
> + Support for NAND flash on Freescale/NXP i.MX devices. This is for the
> + "MXS" series: i.MX23/28 and all i.MX6 and later chips. It is not for
> + the "MXC" series of i.MX processors in the i.MX 21 to 53 range. See
> + the i.MX "msc" driver for those chips.
s/msc/mxc/
In the kernel this driver is known as GPMI nand driver. Maybe we should
add that term here as well?
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2021-05-27 7:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 6:48 Trent Piepho
2021-05-27 7:16 ` Sascha Hauer [this message]
2021-05-27 8:21 ` Trent Piepho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210527071628.GD19819@pengutronix.de \
--to=sha@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=tpiepho@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox