mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: sha@pengutronix.de, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 2/5] fixup! net: eqos: Rockchip support
Date: Wed,  9 Jun 2021 10:55:09 +0200	[thread overview]
Message-ID: <20210609085512.3865-3-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20210609085512.3865-1-a.fatoum@pengutronix.de>

The rk3568 requests some extra clocks, which aren't needed/available for
other SoCs, like the rk3399. To make the driver easier to extend, split
up the clk array into common clocks, needed by all variants and extra
clocks, which are per-variant. This will come in handy for extending
the driver later.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/net/designware_rockchip.c | 80 +++++++++++++++++++++----------
 1 file changed, 56 insertions(+), 24 deletions(-)

diff --git a/drivers/net/designware_rockchip.c b/drivers/net/designware_rockchip.c
index 79c514e73054..a4c7bfe925db 100644
--- a/drivers/net/designware_rockchip.c
+++ b/drivers/net/designware_rockchip.c
@@ -20,11 +20,14 @@ struct rk_gmac_ops {
 	void (*set_to_rmii)(struct eqos *eqos);
 	void (*set_speed)(struct eqos *eqos, int speed);
 	void (*integrated_phy_powerup)(struct eqos *eqos);
+
+	const struct clk_bulk_data *extra_clks;
+	unsigned num_extra_clks;
 };
 
 struct eqos_rk_gmac {
-	struct clk_bulk_data *clks;
-	int num_clks;
+	struct clk_bulk_data *common_clks;
+	struct clk_bulk_data *extra_clks;
 	bool clock_input;
 	const struct rk_gmac_ops *ops;
 	struct regmap *grf;
@@ -41,9 +44,6 @@ enum {
 	CLK_MAC_REFOUT,
 	CLK_MAC_ACLK,
 	CLK_MAC_PCLK,
-	CLK_MAC_SPEED,
-	CLK_PTP_REF,
-	CLK_XPCS_PCLK,
 };
 
 static const struct clk_bulk_data rk_gmac_clks[] = {
@@ -53,9 +53,6 @@ static const struct clk_bulk_data rk_gmac_clks[] = {
 	[CLK_MAC_REFOUT]  = { .id = "clk_mac_refout" },
 	[CLK_MAC_ACLK]    = { .id = "aclk_mac" },
 	[CLK_MAC_PCLK]    = { .id = "pclk_mac" },
-	[CLK_MAC_SPEED]   = { .id = "clk_mac_speed" },
-	[CLK_PTP_REF]     = { .id = "ptp_ref" },
-	[CLK_XPCS_PCLK]   = { .id = "pclk_xpcs" },
 };
 
 static inline struct eqos_rk_gmac *to_rk_gmac(struct eqos *eqos)
@@ -94,7 +91,7 @@ static unsigned long eqos_get_csr_clk_rate_rk_gmac(struct eqos *eqos)
 {
 	struct eqos_rk_gmac *priv = to_rk_gmac(eqos);
 
-	return clk_get_rate(priv->clks[CLK_STMMACETH].clk);
+	return clk_get_rate(priv->common_clks[CLK_STMMACETH].clk);
 }
 
 static void rk3568_set_to_rgmii(struct eqos *eqos,
@@ -142,6 +139,18 @@ static void rk3568_set_to_rmii(struct eqos *eqos)
 		     RK3568_GMAC_PHY_INTF_SEL_RMII);
 }
 
+enum {
+	CLK_MAC_SPEED,
+	CLK_PTP_REF,
+	CLK_XPCS_PCLK,
+};
+
+static const struct clk_bulk_data rk3568_gmac_clks[] = {
+	[CLK_MAC_SPEED]   = { .id = "clk_mac_speed" },
+	[CLK_PTP_REF]     = { .id = "ptp_ref" },
+	[CLK_XPCS_PCLK]   = { .id = "pclk_xpcs" },
+};
+
 static void rk3568_set_gmac_speed(struct eqos *eqos, int speed)
 {
 	struct eqos_rk_gmac *priv = to_rk_gmac(eqos);
@@ -164,7 +173,7 @@ static void rk3568_set_gmac_speed(struct eqos *eqos, int speed)
 		return;
 	}
 
-	ret = clk_set_rate(priv->clks[CLK_MAC_SPEED].clk, rate);
+	ret = clk_set_rate(priv->extra_clks[CLK_MAC_SPEED].clk, rate);
 	if (ret)
 		dev_err(dev, "%s: set clk_mac_speed rate %ld failed %d\n",
 			__func__, rate, ret);
@@ -174,6 +183,9 @@ static const struct rk_gmac_ops rk3568_ops = {
 	.set_to_rgmii = rk3568_set_to_rgmii,
 	.set_to_rmii = rk3568_set_to_rmii,
 	.set_speed = rk3568_set_gmac_speed,
+
+	.extra_clks = rk3568_gmac_clks,
+	.num_extra_clks = ARRAY_SIZE(rk3568_gmac_clks),
 };
 
 static int rk_gmac_powerup(struct eqos *eqos)
@@ -221,6 +233,33 @@ static void eqos_rk_adjust_link(struct eth_device *edev)
 	eqos_adjust_link(edev);
 }
 
+static struct clk_bulk_data *eqos_rk_enable_clocks(struct device_d *dev,
+						   const struct clk_bulk_data *_clks,
+						   unsigned num_clks)
+{
+	struct clk_bulk_data *clks;
+	int ret;
+
+	if (!num_clks)
+		return NULL;
+
+	clks = xmemdup(_clks, num_clks * sizeof(*clks));
+
+	ret = clk_bulk_get(dev, num_clks, clks);
+	if (ret) {
+		dev_err(dev, "Failed to get common clks: %s\n", strerror(-ret));
+		return ERR_PTR(ret);
+	}
+
+	ret = clk_bulk_enable(num_clks, clks);
+	if (ret) {
+		dev_err(dev, "Failed to enable common clks: %s\n", strerror(-ret));
+		return ERR_PTR(ret);
+	}
+
+	return clks;
+}
+
 static int eqos_init_rk_gmac(struct device_d *dev, struct eqos *eqos)
 {
 	struct device_node *np = dev->device_node;
@@ -257,21 +296,14 @@ static int eqos_init_rk_gmac(struct device_d *dev, struct eqos *eqos)
 	priv->rx_delay = 0x10;
 	of_property_read_u32(np, "rx_delay", &priv->rx_delay);
 
-	priv->num_clks = ARRAY_SIZE(rk_gmac_clks);
-	priv->clks = xmalloc(priv->num_clks * sizeof(*priv->clks));
-	memcpy(priv->clks, rk_gmac_clks, sizeof rk_gmac_clks);
+	priv->common_clks = eqos_rk_enable_clocks(dev, rk_gmac_clks, ARRAY_SIZE(rk_gmac_clks));
+	if (IS_ERR(priv->common_clks))
+		return PTR_ERR(priv->common_clks);
 
-	ret = clk_bulk_get(dev, priv->num_clks, priv->clks);
-	if (ret) {
-		dev_err(dev, "Failed to get clks: %s\n", strerror(-ret));
-		return ret;
-	}
-
-	ret = clk_bulk_enable(priv->num_clks, priv->clks);
-	if (ret) {
-		dev_err(dev, "Failed to enable clks: %s\n", strerror(-ret));
-		return ret;
-	}
+	priv->extra_clks = eqos_rk_enable_clocks(dev, priv->ops->extra_clks,
+						 priv->ops->num_extra_clks);
+	if (IS_ERR(priv->extra_clks))
+		return PTR_ERR(priv->extra_clks);
 
 	rk_gmac_powerup(eqos);
 
-- 
2.29.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


  parent reply	other threads:[~2021-06-09  9:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-09  8:55 [PATCH 0/5] fixups for Designware EQOS MAC " Ahmad Fatoum
2021-06-09  8:55 ` [PATCH 1/5] fixup! net: eqos: " Ahmad Fatoum
2021-06-09  8:55 ` Ahmad Fatoum [this message]
2021-06-09 11:33   ` [PATCH 2/5] " Sascha Hauer
2021-06-09  8:55 ` [PATCH 3/5] " Ahmad Fatoum
2021-06-09  8:55 ` [PATCH 4/5] " Ahmad Fatoum
2021-06-09  8:55 ` [PATCH 5/5] " Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210609085512.3865-3-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=sha@pengutronix.de \
    --subject='Re: [PATCH 2/5] fixup'\!' net: eqos: Rockchip support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox