mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] drivers: drop unused usb_gadget_{map,unmap}_request()
Date: Tue, 15 Jun 2021 11:22:13 +0200	[thread overview]
Message-ID: <20210615092213.GH9782@pengutronix.de> (raw)
In-Reply-To: <20210614142833.86544-1-antonynpavlov@gmail.com>

On Mon, Jun 14, 2021 at 05:28:33PM +0300, Antony Pavlov wrote:
> There is no code that is dependent on
> usb_gadget_{map,unmap}_request().

My first reaction was: But maybe there *should* be code depending on
that, but

> -#ifdef	CONFIG_KERNEL_HAS_DMA
> -
> -int usb_gadget_map_request(struct usb_gadget *gadget,
> -		struct usb_request *req, int is_in)
> -{
> -	if (req->length == 0)
> -		return 0;
> -
> -	if (req->num_sgs) {
> -		int     mapped;
> -
> -		mapped = dma_map_sg(&gadget->dev, req->sg, req->num_sgs,
> -				is_in ? DMA_TO_DEVICE : DMA_FROM_DEVICE);

Trying to use it would at least fail when trying to link this. We don't
have any implementation for dma_map_sg().

So ok to remove this nonfunctional code.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


      reply	other threads:[~2021-06-15 15:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-14 14:28 Antony Pavlov
2021-06-15  9:22 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210615092213.GH9782@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --subject='Re: [PATCH] drivers: drop unused usb_gadget_{map,unmap}_request()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox