mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] clk: bail out early when rate is already desired one
Date: Wed, 16 Jun 2021 10:29:45 +0200	[thread overview]
Message-ID: <20210616082945.GR9782@pengutronix.de> (raw)
In-Reply-To: <8d61da9c-a55a-9c98-2918-7f9c95df324f@pengutronix.de>

On Mon, Jun 07, 2021 at 05:46:12PM +0200, Ahmad Fatoum wrote:
> 
> 
> On 07.06.21 16:12, Sascha Hauer wrote:
> > Return successfully from clk_set_rate() when the rate is already the
> > desired one. This prevents a failure in clk_set_rate() when the current
> > clock doesn't have a set_rate hook.
> > 
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ---
> >  drivers/clk/clk.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> > index 8b90f30486..ba726c342c 100644
> > --- a/drivers/clk/clk.c
> > +++ b/drivers/clk/clk.c
> > @@ -169,6 +169,9 @@ int clk_set_rate(struct clk *clk, unsigned long rate)
> >  	if (IS_ERR(clk))
> >  		return PTR_ERR(clk);
> >  
> > +	if (clk_get_rate(clk) == clk_round_rate(clk, rate))
> > +		return 0;
> > +
> >  	if (!clk->ops->set_rate)
> >  		return -ENOSYS;
> 
> 
> This means we can drop 459bf1fd31da ("ARM: clk: rk3188: don't set same
> clk rate twice"), right?

Indeed, yes. This part was lost with "clk: rockchip: Update to current
Linux" anyway, so nothing to do here.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


      reply	other threads:[~2021-06-16  8:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-07 14:12 Sascha Hauer
2021-06-07 15:46 ` Ahmad Fatoum
2021-06-16  8:29   ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210616082945.GR9782@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --subject='Re: [PATCH] clk: bail out early when rate is already desired one' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox