mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] common: bbu: only add available handlers
Date: Mon, 21 Jun 2021 06:38:54 +0200	[thread overview]
Message-ID: <20210621043854.GH9782@pengutronix.de> (raw)
In-Reply-To: <20210618120557.2192098-1-r.czerwinski@pengutronix.de>

On Fri, Jun 18, 2021 at 02:05:57PM +0200, Rouven Czerwinski wrote:
> A board may have multiple handlers registered:
> 
>   registered update handlers:
>     SD          -> /dev/mmc0.barebox
>   * eMMC        -> /dev/mmc1
> 
> However when using the usbgadget with the -b command line argument,
> fastboot will stat all devicefiles listed in the handlers and will fail
> if i.e. the SD card is not available:
> 
>   usbgadget -A /dev/mmc1(root) -b
>   udc0: registering UDC driver [g_multi]
>   multi_bind: creating Fastboot function
>   ERROR: g_multi udc0: failed to start g_multi: -2
>   usbgadget: No such file or directory
> 
> To fix this, check the availability of handlers before adding them to
> the list and skip those that are not available with an info level message.
> 
> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> ---
>  common/bbu.c | 23 +++++++++++++++++++++--
>  1 file changed, 21 insertions(+), 2 deletions(-)

Applied with some whitespace changes, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


      parent reply	other threads:[~2021-06-21  4:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18 12:05 Rouven Czerwinski
2021-06-18 12:05 ` [PATCH 2/2] common: bbu: add pr_fmt Rouven Czerwinski
2021-06-21  4:38 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210621043854.GH9782@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=r.czerwinski@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox