[PATCH] reset: stm32: remove implicit sizeof(long) == 4 expectation

[PATCH] reset: stm32: remove implicit sizeof(long) == 4 expectation

[Ahmad Fatoum]

There is no relation between sizeof(long) and the size of the register
of the reset controller on STM32 CPUs. They just happen to be both 32-bit
in the current configuration. U-Boot already removed the BITS_PER_LONG,
so do likewise.

Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
---
 drivers/reset/reset-stm32.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/reset/reset-stm32.c b/drivers/reset/reset-stm32.c
index a4498f573bb6..2ef00859c48b 100644
--- a/drivers/reset/reset-stm32.c
+++ b/drivers/reset/reset-stm32.c
@@ -81,8 +81,8 @@ static u32 stm32_reset_status(struct stm32_reset *priv, unsigned long bank)
 
 static void stm32_reset(struct stm32_reset *priv, unsigned long id, bool assert)
 {
-	int bank = (id / BITS_PER_LONG) * 4;
-	int offset = id % BITS_PER_LONG;
+	int bank = (id / 32) * 4;
+	int offset = id % 32;
 
 	priv->ops->reset(priv->base + bank, offset, assert);
 }
-- 
2.32.0.rc0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] reset: stm32: remove implicit sizeof(long) == 4 expectation

[Sascha Hauer]

On Tue, Jun 22, 2021 at 08:23:32PM +0200, Ahmad Fatoum wrote:
> There is no relation between sizeof(long) and the size of the register
> of the reset controller on STM32 CPUs. They just happen to be both 32-bit
> in the current configuration. U-Boot already removed the BITS_PER_LONG,
> so do likewise.
> 
> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
> ---
>  drivers/reset/reset-stm32.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox