mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Michael Tretter <m.tretter@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH v2 2/7] clk: zynqmp: do not enable already enabled clocks
Date: Thu, 24 Jun 2021 17:00:49 +0200	[thread overview]
Message-ID: <20210624150054.1205422-3-m.tretter@pengutronix.de> (raw)
In-Reply-To: <20210624150054.1205422-1-m.tretter@pengutronix.de>

The pmu fw manages the permissions who can enable/disable the clocks.

There are a few clocks (TOPSW_LSBUS and LSBUS) which are exposed to
Barebox and Barebox assumes that is has to enable the clocks. However,
the pmu fw considers the clocks under its control and returns a
permission denied for the clock enable request.

Assume that clocks that are already enabled don't need to be enable by
Barebox to avoid the permission denied errors.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---
Changelog:

v2: none
---
 drivers/clk/zynqmp/clk-gate-zynqmp.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/clk/zynqmp/clk-gate-zynqmp.c b/drivers/clk/zynqmp/clk-gate-zynqmp.c
index a3b9ee21e506..493c1dfeaaa3 100644
--- a/drivers/clk/zynqmp/clk-gate-zynqmp.c
+++ b/drivers/clk/zynqmp/clk-gate-zynqmp.c
@@ -28,6 +28,9 @@ static int zynqmp_clk_gate_enable(struct clk_hw *hw)
 {
 	struct zynqmp_clk_gate *gate = to_zynqmp_clk_gate(hw);
 
+	if (clk_hw_is_enabled(hw))
+		return 0;
+
 	return gate->ops->clock_enable(gate->clk_id);
 }
 
-- 
2.30.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


  parent reply	other threads:[~2021-06-24 15:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-24 15:00 [PATCH v2 0/7] ZynqMP: Cleanup and extend board support Michael Tretter
2021-06-24 15:00 ` [PATCH v2 1/7] ARM: zynqmp: set reset source Michael Tretter
2021-06-24 15:00 ` Michael Tretter [this message]
2021-06-24 15:00 ` [PATCH v2 3/7] dts: zcu104: add Barebox environment Michael Tretter
2021-06-24 15:00 ` [PATCH v2 4/7] ARM: zynqmp: add update handler Michael Tretter
2021-06-24 15:00 ` [PATCH v2 5/7] ARM: zynqmp: zcu104: register " Michael Tretter
2021-06-24 15:00 ` [PATCH v2 6/7] ARM: zynqmp: defconfig: enable more features Michael Tretter
2021-06-24 15:00 ` [PATCH v2 7/7] Documentation: zynqmp: add some documentation Michael Tretter
2021-06-25  7:39 ` [PATCH v2 0/7] ZynqMP: Cleanup and extend board support Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210624150054.1205422-3-m.tretter@pengutronix.de \
    --to=m.tretter@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --subject='Re: [PATCH v2 2/7] clk: zynqmp: do not enable already enabled clocks' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox