From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] driver: add CONFIG_DEBUG_PROBES
Date: Mon, 28 Jun 2021 22:37:51 +0200 [thread overview]
Message-ID: <20210628203751.GS9782@pengutronix.de> (raw)
In-Reply-To: <20210628070345.13838-1-a.fatoum@pengutronix.de>
On Mon, Jun 28, 2021 at 09:03:45AM +0200, Ahmad Fatoum wrote:
> CONFIG_DEBUG_INITCALLS can be very useful to roughly pinpoint what
> causes barebox to hang. With deep probe, most probes run at the same
> initcall level making the debug option much less useful.
>
> Add a new CONFIG_DEBUG_PROBES that will instead log whenever a probe is
> invoked. The text's horizontal alignment is increased with each
> recursive probe making the option suitable for debugging some deep probe
> issues as well.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> common/Kconfig | 4 ++++
> drivers/base/driver.c | 17 +++++++++++++++--
> 2 files changed, 19 insertions(+), 2 deletions(-)
Nice. I applied with one change I hope you're ok with:
> + depth++;
> +
> + pr_report_probe("%*sprobe-> %s\n", depth, "", dev_name(dev));
I changed the indentation to 4 here.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2021-06-28 20:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 7:03 Ahmad Fatoum
2021-06-28 20:37 ` Sascha Hauer [this message]
2021-06-29 6:39 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210628203751.GS9782@pengutronix.de \
--to=sha@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox