mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: "Karfich, Oleg" <Oleg.Karfich@wago.com>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: [PATCH] net: cpsw: fix ethernet bringup in case of a fixed-link phy
Date: Mon, 4 Oct 2021 13:07:33 +0200	[thread overview]
Message-ID: <20211004110733.GW28453@pengutronix.de> (raw)
In-Reply-To: <1630414594-10601-1-git-send-email-oleg.karfich@wago.com>

On Tue, Aug 31, 2021 at 12:57:01PM +0000, Karfich, Oleg wrote:
> In case of a fixed-link phy the cpsw_adjust_link() function is
> called directly in phy_device_attach() and configures the MACCONTROL
> register. Right after this configuration cpsw_init() is called and
> resets the MACCONTROL register.
> Fix this by initializing the slave before connecting the phy device in
> cpsw_open().
> 
> Signed-off-by: Oleg Karfich <oleg.karfich@wago.com>
> ---
>  drivers/net/cpsw.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/net/cpsw.c b/drivers/net/cpsw.c
> index b01e7ac..4a8f9e6 100644
> --- a/drivers/net/cpsw.c
> +++ b/drivers/net/cpsw.c
> @@ -901,13 +901,13 @@ static int cpsw_open(struct eth_device *edev)
>  
>  	dev_dbg(&slave->dev, "* %s\n", __func__);
>  
> +	cpsw_slave_init(slave, priv);
> +
>  	ret = phy_device_connect(edev, NULL, slave->phy_id,
>  				 cpsw_adjust_link, 0, slave->phy_if);
>  	if (ret)
>  		return ret;
>  
> -	cpsw_slave_init(slave, priv);
> -
>  	return 0;
>  }
>  
> -- 
> 2.7.4
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


      reply	other threads:[~2021-10-04 11:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-31 12:57 Karfich, Oleg
2021-10-04 11:07 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211004110733.GW28453@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=Oleg.Karfich@wago.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox