mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: i.MX8MP: move SCTR enabling into imx8mp_cpu_lowlevel_init
Date: Mon, 4 Oct 2021 14:14:00 +0200	[thread overview]
Message-ID: <20211004121400.GJ28453@pengutronix.de> (raw)
In-Reply-To: <20210830115325.24905-1-a.fatoum@pengutronix.de>

On Mon, Aug 30, 2021 at 01:53:25PM +0200, Ahmad Fatoum wrote:
> We already do this SCTR poking in imx8mm_cpu_lowlevel_init. If the EVK
> needs it, other boards should as well, thus move it to a more generic
> place.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  arch/arm/boards/nxp-imx8mp-evk/lowlevel.c | 5 -----
>  arch/arm/mach-imx/cpu_init.c              | 4 +---
>  2 files changed, 1 insertion(+), 8 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/arch/arm/boards/nxp-imx8mp-evk/lowlevel.c b/arch/arm/boards/nxp-imx8mp-evk/lowlevel.c
> index 3298ded5866d..6cb109ae1675 100644
> --- a/arch/arm/boards/nxp-imx8mp-evk/lowlevel.c
> +++ b/arch/arm/boards/nxp-imx8mp-evk/lowlevel.c
> @@ -179,11 +179,6 @@ static __noreturn noinline void nxp_imx8mp_evk_start(void)
>  
>  ENTRY_FUNCTION(start_nxp_imx8mp_evk, r0, r1, r2)
>  {
> -	void __iomem *ccm = IOMEM(MX8M_CCM_BASE_ADDR);
> -
> -	writel(IMX8M_CCM_CCGR_SETTINGn_NEEDED(0),
> -	       ccm + IMX8M_CCM_CCGRn_SET(IMX8M_CCM_CCGR_SCTR));
> -
>  	imx8mp_cpu_lowlevel_init();
>  
>  	relocate_to_current_adr();
> diff --git a/arch/arm/mach-imx/cpu_init.c b/arch/arm/mach-imx/cpu_init.c
> index a034b5a9a500..ea1c67469122 100644
> --- a/arch/arm/mach-imx/cpu_init.c
> +++ b/arch/arm/mach-imx/cpu_init.c
> @@ -76,9 +76,7 @@ void imx8mm_cpu_lowlevel_init(void)
>  }
>  
>  void imx8mp_cpu_lowlevel_init(void)
> -{
> -	imx8m_cpu_lowlevel_init();
> -}
> +	__alias(imx8mm_cpu_lowlevel_init);
>  
>  void imx8mq_cpu_lowlevel_init(void)
>  {
> -- 
> 2.30.2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


      reply	other threads:[~2021-10-04 12:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-30 11:53 Ahmad Fatoum
2021-10-04 12:14 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211004121400.GJ28453@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox