mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] fs: ramfs: drop free of unused dev->priv
@ 2021-10-30 14:17 Ahmad Fatoum
  2021-11-01  9:06 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2021-10-30 14:17 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

This probably was a benign free(NULL) so far, but it serves no point, so
drop it.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 fs/ramfs.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/ramfs.c b/fs/ramfs.c
index 14ba87766098..bdaa91dd9e1b 100644
--- a/fs/ramfs.c
+++ b/fs/ramfs.c
@@ -447,7 +447,6 @@ static int ramfs_probe(struct device_d *dev)
 
 static void ramfs_remove(struct device_d *dev)
 {
-	free(dev->priv);
 }
 
 static struct fs_driver_d ramfs_driver = {
-- 
2.30.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] fs: ramfs: drop free of unused dev->priv
  2021-10-30 14:17 [PATCH] fs: ramfs: drop free of unused dev->priv Ahmad Fatoum
@ 2021-11-01  9:06 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2021-11-01  9:06 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox

On Sat, Oct 30, 2021 at 04:17:07PM +0200, Ahmad Fatoum wrote:
> This probably was a benign free(NULL) so far, but it serves no point, so
> drop it.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  fs/ramfs.c | 1 -
>  1 file changed, 1 deletion(-)

Applied, thanks

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-01  9:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-30 14:17 [PATCH] fs: ramfs: drop free of unused dev->priv Ahmad Fatoum
2021-11-01  9:06 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox