From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 01 Nov 2021 10:05:47 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mhTGF-0006yQ-Ic for lore@lore.pengutronix.de; Mon, 01 Nov 2021 10:05:47 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mhTGE-0004gj-Kw for lore@pengutronix.de; Mon, 01 Nov 2021 10:05:47 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:From:In-Reply-To:MIME-Version: References:Message-ID:Subject:Cc:To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=FxV+Rb2GU/6gyXmqXQ9Xdvtp84f1887PEbhRxY6xoDI=; b=fwKKYlcvHeDGsP5LYmsM4aAKot JZLC5FfQgJQadBZvzWISVbv+TywPCrDWYApDyudYFdQEbr5P/m+3/uJ50WoM24ianxUgWoRn6e9dg erUTG70qsNs6x2+qQJ8zAWKbTvb/T2rkSvbpaC4BzOyUKPP+DNtsjC4st3hGyuZu/gvHYlDFXq5Dy z1wv0InFJyFYwHGi8EBAJPlMFuzPgws8ME7ZrqMGVO/E6ddJYZas6A0BuJjH0wY1Mgr4UtYuChtBd to33kD0xcw+XxZ6tzUVJ7rDM39GPWXiyTBaXqk95s6+y/K4mcCtTxgWIk0NMXDBbjNxtgB4rJwdSc lPSXdoHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhTEp-00FjgB-9t; Mon, 01 Nov 2021 09:04:19 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhTEk-00FjfJ-P5 for barebox@lists.infradead.org; Mon, 01 Nov 2021 09:04:16 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mhTEj-0004Ma-HI; Mon, 01 Nov 2021 10:04:13 +0100 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1mhTEj-0000Se-8P; Mon, 01 Nov 2021 10:04:13 +0100 Date: Mon, 1 Nov 2021 10:04:13 +0100 To: Ahmad Fatoum Cc: barebox@lists.infradead.org Message-ID: <20211101090413.GN25698@pengutronix.de> References: <20211027060150.28184-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211027060150.28184-1-a.fatoum@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 10:04:03 up 256 days, 12:27, 121 users, load average: 0.12, 0.24, 0.20 User-Agent: Mutt/1.10.1 (2018-07-13) From: Sascha Hauer X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211101_020414_843397_DC170F6D X-CRM114-Status: GOOD ( 22.34 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:e::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.8 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH] fixup! scripts: Add common library functions X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On Wed, Oct 27, 2021 at 08:01:50AM +0200, Ahmad Fatoum wrote: > scripts: common: mmap mutable memory in read_file_2 > > imx-usb-loader expects the file buffer contents to be mutable as it > will patch out references to plugin and DCD segments. > > With the consolidation of the different file read helpers, the > buffer is no longer always malloc'd, but a read-only shared > mapping is attempted first and if it succeeds, imx-usb-loader > will seg fault during fixups. > > As we don't want to modify the underlying file, switch to a writable > private mapping to remedy this. > > Signed-off-by: Ahmad Fatoum > --- > scripts/common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox