From: Joacim Zetterling <joaze@westermo.com>
To: Sascha Hauer <sha@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v3] Fix problem with imx_ddrc_sdram_size calc
Date: Mon, 15 Nov 2021 15:05:39 +0100 [thread overview]
Message-ID: <20211115140539.GA118449@wsevst-c0022> (raw)
In-Reply-To: <20211105093927.GI25698@pengutronix.de>
On Fri, Nov 05, 2021 at 10:39:27AM +0100, Sascha Hauer wrote:
> Hi Joacim,
>
> On Mon, Nov 01, 2021 at 01:11:09PM +0100, Joacim Zetterling wrote:
> > There was some issues with the imx_ddrc_sdram_size calculation.
> >
> > If we compare the imx8mn DDR4 evk against the LPDDR4 variant in
> > code and in the datasheets, we see the following:
> >
> > DDR4 LPDDR4
> > ========================
> > Bus width 16 16
> > Rank 1 1
> > Ranks 1 1
> > Banks 4 8
> > Banks grps 2 1
> > Rows 17 15
> > Col 10 10
> >
> > This gives us the following problems:
> >
> > 1. Bus width problem.
> > Does not support 16 bit SDRAM bus mode, only 32 bit supported
> >
> > 2. Row size problem.
> > Only up to 16 bit row size support.
> >
> > 3. Bank groups support.
> > Only support of 1 bank group.
> >
> > 4. Bit count problem.
> > The imx_ddrc_count_bits function does not do a correct count.
>
> Could you split this into four patches fixing one problem at a time?
> I am not sure the problems can be separated from each other entirely,
> but splitting this up would make it much easier to understand the
> problems and also their fixes. We'll be glad having smaller patches
> should we ever have to look at this again.
>
> Sascha
I agree with You that the problems can not be separated completely.
But I will try to do my best. Do You prefer a patch set or separately
patches or a combination of them both?
>
>
> --
> Pengutronix e.K. | |
> Steuerwalder Str. 21 | https://urldefense.com/v3/__http://www.pengutronix.de/__;!!I9LPvj3b!Wb3fL9pyR56wlJRdVF8DNTWkyIIzz62heX4PoFnCqATftaC0TnNM4XTgg1tc9ok$ |
> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2021-11-15 14:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 12:11 Joacim Zetterling
2021-11-05 9:39 ` Sascha Hauer
2021-11-15 14:05 ` Joacim Zetterling [this message]
2021-11-17 7:23 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211115140539.GA118449@wsevst-c0022 \
--to=joaze@westermo.com \
--cc=barebox@lists.infradead.org \
--cc=sha@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox