From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] clk: bulk: improve error message on failure to get
Date: Mon, 13 Dec 2021 23:14:24 +0100 [thread overview]
Message-ID: <20211213221424.GD6003@pengutronix.de> (raw)
In-Reply-To: <20211202074224.193631-1-a.fatoum@pengutronix.de>
On Thu, Dec 02, 2021 at 08:42:24AM +0100, Ahmad Fatoum wrote:
> We didn't have the need to handle %pOF specially yet, but for the error
> message in clk-bulk, not readily knowing what component couldn't get its
> clocks is annoying. Print the node name directly and change the error
> code to the error string if those are compiled in.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> drivers/clk/clk-bulk.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/clk/clk-bulk.c b/drivers/clk/clk-bulk.c
> index d530b4f968e6..4510283962ae 100644
> --- a/drivers/clk/clk-bulk.c
> +++ b/drivers/clk/clk-bulk.c
> @@ -88,8 +88,8 @@ static int __must_check of_clk_bulk_get(struct device_node *np, int num_clks,
> clks[i].clk = of_clk_get(np, i);
> if (IS_ERR(clks[i].clk)) {
> ret = PTR_ERR(clks[i].clk);
> - pr_err("%pOF: Failed to get clk index: %d ret: %d\n",
> - np, i, ret);
> + pr_err("%s: Failed to get clk index: %d ret: %pe\n",
> + np->name, i, clks[i].clk);
> clks[i].clk = NULL;
> goto err;
> }
> --
> 2.30.2
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2021-12-13 22:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 7:42 Ahmad Fatoum
2021-12-13 22:14 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211213221424.GD6003@pengutronix.de \
--to=sha@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox