From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 07 Feb 2022 09:18:56 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nGzEe-0084cl-Kd for lore@lore.pengutronix.de; Mon, 07 Feb 2022 09:18:56 +0100 Received: from bombadil.infradead.org ([198.137.202.133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nGzEd-0006Hz-DM for lore@pengutronix.de; Mon, 07 Feb 2022 09:18:56 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:From:In-Reply-To:MIME-Version: References:Message-ID:Subject:Cc:To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Y4EE0faOC7DzeVXiHxoSg0KI/Fmbudpze1kqlzOPhx0=; b=u9wG6VDB6MVSH1KJ+xNoBmjeR4 CGAOXnZhg0DScoxW/cj1kyH6/cE0cVEjet1Xg9GQXhDYiGzdxkqQaHS4daCcv9mj9YAvHTM5TzEIk +lxLlQ+89H9CpOPLlr3v8uEGhEUN6Sccquc3Gb+X5Iz5TuDrSfWqZtnzfxWMWQ6nHlmmbNYeMLrFp 1YUCr/Ih22rzd09svGtaawxu9cmcaH4J7Bd9MJYX2Ft5gAHVsGo1fQgn8+qnt/ttq4pHX63BSL8Rn 15MNSe1Qh6HJzoaGXtV0Be4SpZTZKITNsNs/pDKigXnwPzV0xNFcOgc5k2AtetkbCl+cn4+q965Pd NreN/0/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nGzDS-009JtI-Re; Mon, 07 Feb 2022 08:17:42 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nGzDI-009JsG-8t for barebox@lists.infradead.org; Mon, 07 Feb 2022 08:17:33 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nGzDH-00065E-24; Mon, 07 Feb 2022 09:17:31 +0100 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nGzDG-000693-PX; Mon, 07 Feb 2022 09:17:30 +0100 Date: Mon, 7 Feb 2022 09:17:30 +0100 To: Ahmad Fatoum Cc: barebox@lists.infradead.org Message-ID: <20220207081730.GB18637@pengutronix.de> References: <20220207075621.1014381-1-a.fatoum@pengutronix.de> <20220207075621.1014381-4-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220207075621.1014381-4-a.fatoum@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:15:20 up 58 days, 17:00, 83 users, load average: 0.38, 0.41, 0.31 User-Agent: Mutt/1.10.1 (2018-07-13) From: Sascha Hauer X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220207_001732_341494_E227C777 X-CRM114-Status: GOOD ( 21.51 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" X-SA-Exim-Connect-IP: 198.137.202.133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.6 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH 4/5] of: silence of_diff output for negative indents X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On Mon, Feb 07, 2022 at 08:56:20AM +0100, Ahmad Fatoum wrote: > Negative indents just led to strange behavior so far. Repurpose them to > mean that the caller is not interested in console output. This makes > them useful for negative tests (Sanity check that two different nodes > are indeed different). > > Signed-off-by: Ahmad Fatoum > --- > drivers/of/base.c | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/drivers/of/base.c b/drivers/of/base.c > index 99be24254203..ffa79785f80e 100644 > --- a/drivers/of/base.c > +++ b/drivers/of/base.c > @@ -2087,6 +2087,8 @@ int of_diff(struct device_node *a, struct device_node *b, int indent) Can we add a bool do_print = indent >= 0; variable and use it for the tests below? I think this makes the code a bit clearer. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox