From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 12 Apr 2022 10:15:52 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1neBgn-00Gyp3-Ns for lore@lore.pengutronix.de; Tue, 12 Apr 2022 10:15:52 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1neBgl-0006W1-1L for lore@pengutronix.de; Tue, 12 Apr 2022 10:15:51 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7IQJd6kUV9aloel211LIVEwi86zLEVw+pwmfBkbmvUE=; b=F/F426AlB9ZXXs C5JRnhXaP4QjGb2oLG5x07aPlL9Ck3Q94wuafqbinFyVkA95zuc8XLKrzoeZJJwEiYwlzSEEahYFP G5ZKURjYwvRcr5Qb6IlEEp3KrIO+581126C911/hduS1E6cvfeWJBGrnz6bHxyG78a2nmc2VQ/StY cYPp8A7EHlM6Qh1tB/iWGjN0OswgKqhVN41qQD8hjRHUpJ239H+tRgQOWiosNBmjk8Wj6e/in1XK5 2fNVd9AA2W6FVUHvNZN5PAVARfBk7EwhB2v9crdc/wBSxkq8eSZB5GSwfwDi71poQoxSZpUv+Xhz+ EWxXTJ7YqAkejZV3oP7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neBfZ-00CUJB-Ni; Tue, 12 Apr 2022 08:14:37 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1neBfU-00CUI5-Ec for barebox@lists.infradead.org; Tue, 12 Apr 2022 08:14:33 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1neBfT-0006Fv-9W; Tue, 12 Apr 2022 10:14:31 +0200 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1neBfT-0001AF-0E; Tue, 12 Apr 2022 10:14:31 +0200 Date: Tue, 12 Apr 2022 10:14:30 +0200 From: Oleksij Rempel To: Sascha Hauer Cc: barebox@lists.infradead.org Message-ID: <20220412081430.GA6930@pengutronix.de> References: <20220408082950.824927-1-o.rempel@pengutronix.de> <20220408082950.824927-2-o.rempel@pengutronix.de> <20220412075827.GV4012@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220412075827.GV4012@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 10:13:54 up 12 days, 20:43, 66 users, load average: 0.08, 0.17, 0.17 User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220412_011432_507219_46941765 X-CRM114-Status: GOOD ( 25.49 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:e::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.6 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH v4 01/13] net: add RX preprocessor support X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On Tue, Apr 12, 2022 at 09:58:27AM +0200, Sascha Hauer wrote: > On Fri, Apr 08, 2022 at 10:29:38AM +0200, Oleksij Rempel wrote: > > Add callback for optional rx_preprocessor. This is needed to add DSA > > switch support and demultiplex traffic received from different switch ports. > > > > Signed-off-by: Oleksij Rempel > > --- > > include/net.h | 3 +++ > > net/net.c | 6 ++++++ > > 2 files changed, 9 insertions(+) > > > > diff --git a/include/net.h b/include/net.h > > index aad28e4f4c..ca9b6cd61e 100644 > > --- a/include/net.h > > +++ b/include/net.h > > @@ -44,9 +44,12 @@ struct eth_device { > > void (*halt) (struct eth_device*); > > int (*get_ethaddr) (struct eth_device*, u8 adr[6]); > > int (*set_ethaddr) (struct eth_device*, const unsigned char *adr); > > + int (*rx_preprocessor) (struct eth_device*, unsigned char **packet, > > + int *length); > > > > struct eth_device *next; > > void *priv; > > + void *rx_preprocessor_priv; > > > > /* phy device may attach itself for hardware timestamping */ > > struct phy_device *phydev; > > diff --git a/net/net.c b/net/net.c > > index fdb9ab826c..dd2ceb396d 100644 > > --- a/net/net.c > > +++ b/net/net.c > > @@ -708,6 +708,12 @@ int net_receive(struct eth_device *edev, unsigned char *pkt, int len) > > goto out; > > } > > > > + if (edev->rx_preprocessor) { > > + ret = edev->rx_preprocessor(edev, &pkt, &len); > > + if (ret == -ENOMSG) > > + return 0; > > ret == -ENOMSG means the packet has been handled by the preprocessor > (and forwarded to the DSA virtual network devices). What about the other > errors that rx_preprocessor can return? Shouldn't we ignore the packet > on other errors? Good point, will update it. Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox