* [PATCH] gpiolib: remove declaration of now unused variable
@ 2022-04-26 6:46 Ahmad Fatoum
2022-04-29 7:11 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2022-04-26 6:46 UTC (permalink / raw)
To: barebox; +Cc: Ahmad Fatoum
Since commit f349b662674e ("gpio: allocate dynamic gpio numbers
top down"), the variable is now unused and warned about, so remove it.
Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
---
drivers/gpio/gpiolib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index c9b33bcd6c2b..10cb7b389555 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -609,7 +609,7 @@ int gpiod_get(struct device_d *dev, const char *_con_id, enum gpiod_flags flags)
int gpiochip_add(struct gpio_chip *chip)
{
- int base, i;
+ int i;
if (chip->base >= 0) {
for (i = 0; i < chip->ngpio; i++) {
--
2.34.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] gpiolib: remove declaration of now unused variable
2022-04-26 6:46 [PATCH] gpiolib: remove declaration of now unused variable Ahmad Fatoum
@ 2022-04-29 7:11 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2022-04-29 7:11 UTC (permalink / raw)
To: Ahmad Fatoum; +Cc: barebox
On Tue, Apr 26, 2022 at 08:46:19AM +0200, Ahmad Fatoum wrote:
> Since commit f349b662674e ("gpio: allocate dynamic gpio numbers
> top down"), the variable is now unused and warned about, so remove it.
>
> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
> ---
> drivers/gpio/gpiolib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, thanks
Sascha
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index c9b33bcd6c2b..10cb7b389555 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -609,7 +609,7 @@ int gpiod_get(struct device_d *dev, const char *_con_id, enum gpiod_flags flags)
>
> int gpiochip_add(struct gpio_chip *chip)
> {
> - int base, i;
> + int i;
>
> if (chip->base >= 0) {
> for (i = 0; i < chip->ngpio; i++) {
> --
> 2.34.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-29 7:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-26 6:46 [PATCH] gpiolib: remove declaration of now unused variable Ahmad Fatoum
2022-04-29 7:11 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox