From: Sascha Hauer <sha@pengutronix.de>
To: Alexander Shiyan <eagle.alexander923@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: OMAP: debug_ll: Use Kconfig UART base address
Date: Thu, 5 May 2022 10:13:53 +0200 [thread overview]
Message-ID: <20220505081353.GL4012@pengutronix.de> (raw)
In-Reply-To: <20220505073604.15065-1-eagle.alexander923@gmail.com>
Hi Alexander,
On Thu, May 05, 2022 at 10:36:04AM +0300, Alexander Shiyan wrote:
> Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
> ---
> arch/arm/boards/afi-gf/lowlevel.c | 2 +-
> arch/arm/boards/beagle/lowlevel.c | 2 +-
> arch/arm/boards/beaglebone/lowlevel.c | 2 +-
> arch/arm/boards/myirtech-x335x/lowlevel.c | 2 +-
> arch/arm/boards/phytec-som-am335x/lowlevel.c | 2 +-
> arch/arm/boards/vscom-baltos/lowlevel.c | 2 +-
> arch/arm/boards/wago-pfc-am35xx/lowlevel.c | 2 +-
> arch/arm/mach-omap/include/mach/debug_ll.h | 43 ++++++++++++--------
> 8 files changed, 33 insertions(+), 24 deletions(-)
>
> diff --git a/arch/arm/boards/afi-gf/lowlevel.c b/arch/arm/boards/afi-gf/lowlevel.c
> index de40f6c5af..9e86b29b2d 100644
> --- a/arch/arm/boards/afi-gf/lowlevel.c
> +++ b/arch/arm/boards/afi-gf/lowlevel.c
> @@ -230,7 +230,7 @@ static noinline int gf_sram_init(void)
>
> am33xx_uart_soft_reset((void *)AM33XX_UART2_BASE);
> am33xx_enable_uart2_pin_mux();
> - omap_uart_lowlevel_init((void *)AM33XX_UART2_BASE);
> + omap_uart_lowlevel_init();
I don't think removing the base address from omap_uart_lowlevel_init()
is a step forward. CONFIG_DEBUG_LL is only one possible usecase for this
function, another one is for regular early console with pbl_set_putc().
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2022-05-05 8:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 7:36 Alexander Shiyan
2022-05-05 7:55 ` Lucas Stach
2022-05-05 8:01 ` Alexander Shiyan
2022-05-05 8:09 ` Ahmad Fatoum
2022-05-05 8:13 ` Sascha Hauer [this message]
2022-05-05 9:42 ` Alexander Shiyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220505081353.GL4012@pengutronix.de \
--to=sha@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=eagle.alexander923@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox