From: Denis Orlov <denorl2009@gmail.com>
To: barebox@lists.infradead.org
Cc: Denis Orlov <denorl2009@gmail.com>
Subject: [PATCH] clk: fix clk_round_rate() behaviour
Date: Mon, 16 May 2022 10:00:49 +0300 [thread overview]
Message-ID: <20220516070049.11963-1-denorl2009@gmail.com> (raw)
Right now this function returns the current rate of the clock in the
case when the round_rate() is not given in the clock's ops. This breaks
clk_set_rate(), which calls clk_round_rate() to check if the resulting
frequency would be the same as the one that is already set.
Make it so that clk_round_rate() returns the frequency that was given as
argument in this case.
Signed-off-by: Denis Orlov <denorl2009@gmail.com>
---
drivers/clk/clk.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 52e309e877..7492717d3c 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -139,16 +139,16 @@ long clk_round_rate(struct clk *clk, unsigned long rate)
if (IS_ERR(clk))
return 0;
+ if (!clk->ops->round_rate)
+ return rate;
+
parent = clk_get_parent(clk);
if (parent)
parent_rate = clk_get_rate(parent);
hw = clk_to_clk_hw(clk);
- if (clk->ops->round_rate)
- return clk->ops->round_rate(hw, rate, &parent_rate);
-
- return clk_get_rate(clk);
+ return clk->ops->round_rate(hw, rate, &parent_rate);
}
long clk_hw_round_rate(struct clk_hw *hw, unsigned long rate)
--
2.20.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2022-05-16 7:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 7:00 Denis Orlov [this message]
2022-05-16 9:07 ` Sascha Hauer
2022-05-19 8:12 ` Денис Орлов
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220516070049.11963-1-denorl2009@gmail.com \
--to=denorl2009@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox